From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Alan Stern <stern@rowland.harvard.edu>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@ti.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] [RFC] usb: gadget: USB_GADGET should depend on HAS_DMA
Date: Fri, 12 Jul 2013 10:39:18 +0300 [thread overview]
Message-ID: <8761wg2pnd.fsf@ashishki-desk.ger.corp.intel.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1307111145160.1276-100000@iolanthe.rowland.org>
Alan Stern <stern@rowland.harvard.edu> writes:
> On Thu, 11 Jul 2013, Geert Uytterhoeven wrote:
>
>> If NO_DMA=y:
>>
>> drivers/built-in.o: In function `dma_set_coherent_mask':
>> include/linux/dma-mapping.h:93: undefined reference to `dma_supported'
>> include/linux/dma-mapping.h:93: undefined reference to `dma_supported'
>> drivers/built-in.o: In function `usb_gadget_unmap_request':
>> drivers/usb/gadget/udc-core.c:91: undefined reference to `dma_unmap_sg'
>> drivers/usb/gadget/udc-core.c:96: undefined reference to `dma_unmap_single'
>> drivers/built-in.o: In function `usb_gadget_map_request':
>> drivers/usb/gadget/udc-core.c:62: undefined reference to `dma_map_sg'
>> drivers/usb/gadget/udc-core.c:71: undefined reference to `dma_map_single'
>> drivers/usb/gadget/udc-core.c:74: undefined reference to `dma_mapping_error'
>>
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> ---
>> This one is very debatable: probably the parts using the DMA API should
>> be factored out, instead of disabling the whole USB gadget subsystem.
>
> Indeed. How does this look instead?
This one is much better. FWIW,
Acked-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Regards,
--
Alex
prev parent reply other threads:[~2013-07-12 7:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 13:54 [PATCH 1/6] usb: dwc3: USB_DWC3 " Geert Uytterhoeven
2013-07-11 13:54 ` [PATCH 2/6] usb: chipidea: USB_CHIPIDEA_UDC " Geert Uytterhoeven
2013-07-11 13:54 ` [PATCH 3/6] usb: gadget: USB_MV_UDC " Geert Uytterhoeven
2013-07-11 13:54 ` [PATCH 4/6] usb: gadget: USB_FOTG210_UDC " Geert Uytterhoeven
2013-07-11 13:54 ` [PATCH 5/6] usb: gadget: USB_MV_U3D " Geert Uytterhoeven
2013-07-11 13:54 ` [PATCH 6/6] [RFC] usb: gadget: USB_GADGET " Geert Uytterhoeven
2013-07-11 15:51 ` Alan Stern
2013-07-12 7:21 ` Geert Uytterhoeven
2013-07-12 15:06 ` [PATCH] USB: GADGET: don't fail when DMA isn't present Alan Stern
2013-07-12 7:39 ` Alexander Shishkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761wg2pnd.fsf@ashishki-desk.ger.corp.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®