mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Prabhakar Lad <prabhakar.csengg@gmail.com>
To: LMML <linux-media@vger.kernel.org>
Cc: DLOS <davinci-linux-open-source@linux.davincidsp.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Subject: [PATCH v2 5/5] media: davinci: vpbe: Replace printk with dev_*
Date: Thu, 18 Jul 2013 20:59:40 +0530	[thread overview]
Message-ID: <1374161380-12762-1-git-send-email-prabhakar.csengg@gmail.com> (raw)

From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>

Use the dev_* message logging API instead of raw printk.

Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
 Posting independent patch of the series,
 http://www.spinics.net/lists/linux-media/msg65701.html
 
 Changes for v2:
 1: Fixed logging levels.
 
 drivers/media/platform/davinci/vpbe.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/media/platform/davinci/vpbe.c b/drivers/media/platform/davinci/vpbe.c
index 33b9660..a3a36e0 100644
--- a/drivers/media/platform/davinci/vpbe.c
+++ b/drivers/media/platform/davinci/vpbe.c
@@ -595,7 +595,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
 	 * matching with device name
 	 */
 	if (NULL == vpbe_dev || NULL == dev) {
-		printk(KERN_ERR "Null device pointers.\n");
+		dev_err(dev, "Null device pointers.\n");
 		return -ENODEV;
 	}
 
@@ -735,7 +735,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
 
 	mutex_unlock(&vpbe_dev->lock);
 
-	printk(KERN_NOTICE "Setting default output to %s\n", def_output);
+	dev_notice(dev, "Setting default output to %s\n", def_output);
 	ret = vpbe_set_default_output(vpbe_dev);
 	if (ret) {
 		v4l2_err(&vpbe_dev->v4l2_dev, "Failed to set default output %s",
@@ -743,7 +743,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
 		return ret;
 	}
 
-	printk(KERN_NOTICE "Setting default mode to %s\n", def_mode);
+	dev_notice(dev, "Setting default mode to %s\n", def_mode);
 	ret = vpbe_set_default_mode(vpbe_dev);
 	if (ret) {
 		v4l2_err(&vpbe_dev->v4l2_dev, "Failed to set default mode %s",
-- 
1.7.9.5


             reply	other threads:[~2013-07-18 15:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-18 15:29 Prabhakar Lad [this message]
2013-07-18 15:40 ` Joe Perches
2013-07-18 15:45   ` Prabhakar Lad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374161380-12762-1-git-send-email-prabhakar.csengg@gmail.com \
    --to=prabhakar.csengg@gmail.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®