From: Joe Perches <joe@perches.com>
To: Prabhakar Lad <prabhakar.csengg@gmail.com>
Cc: LMML <linux-media@vger.kernel.org>,
DLOS <davinci-linux-open-source@linux.davincidsp.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 5/5] media: davinci: vpbe: Replace printk with dev_*
Date: Thu, 18 Jul 2013 08:40:13 -0700 [thread overview]
Message-ID: <1374162013.1949.119.camel@joe-AO722> (raw)
In-Reply-To: <1374161380-12762-1-git-send-email-prabhakar.csengg@gmail.com>
On Thu, 2013-07-18 at 20:59 +0530, Prabhakar Lad wrote:
> Use the dev_* message logging API instead of raw printk.
[]
> diff --git a/drivers/media/platform/davinci/vpbe.c b/drivers/media/platform/davinci/vpbe.c
[]
> @@ -595,7 +595,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
> * matching with device name
> */
> if (NULL == vpbe_dev || NULL == dev) {
> - printk(KERN_ERR "Null device pointers.\n");
> + dev_err(dev, "Null device pointers.\n");
And if dev actually is NULL?
btw: canonical forms for this test are
(if vpbe_dev == NULL || dev == NULL)
or
if (!bpbe_dev || !dev)
I stopped reading here.
next prev parent reply other threads:[~2013-07-18 15:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 15:29 Prabhakar Lad
2013-07-18 15:40 ` Joe Perches [this message]
2013-07-18 15:45 ` Prabhakar Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374162013.1949.119.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®