* [PATCH] power supply: tosa_battery: get rid of irq_to_gpio usage
@ 2013-07-20 23:07 Andrea Adami
2013-08-09 20:44 ` Anton Vorontsov
0 siblings, 1 reply; 2+ messages in thread
From: Andrea Adami @ 2013-07-20 23:07 UTC (permalink / raw)
To: linux-kernel; +Cc: David Woodhouse, Anton Vorontsov, Russell King
Fix
linux/drivers/power/tosa_battery.c:153:2: error: implicit declaration of
function 'irq_to_gpio' [-Werror=implicit-function-declaration]
| pr_info("tosa_bat_gpio irq: %d\n",
gpio_get_value(irq_to_gpio(irq)));
as done for collie_battery.c with
commit 629bcb4b72d49b3631ae3dd0fe1d345820fadfcc
Since 9d08d5d77a355510c2f5657c86b0a4b25acfe72c, irq_to_gpio() is no
longer available but still in use by collie_battery.c. As it's just
for a debug message, just get rid of this call.
Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
---
drivers/power/tosa_battery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/tosa_battery.c b/drivers/power/tosa_battery.c
index 0224de5..f4d80df 100644
--- a/drivers/power/tosa_battery.c
+++ b/drivers/power/tosa_battery.c
@@ -150,7 +150,7 @@ static void tosa_bat_external_power_changed(struct power_supply *psy)
static irqreturn_t tosa_bat_gpio_isr(int irq, void *data)
{
- pr_info("tosa_bat_gpio irq: %d\n", gpio_get_value(irq_to_gpio(irq)));
+ pr_info("tosa_bat_gpio irq\n");
schedule_work(&bat_work);
return IRQ_HANDLED;
}
--
1.8.1.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] power supply: tosa_battery: get rid of irq_to_gpio usage
2013-07-20 23:07 [PATCH] power supply: tosa_battery: get rid of irq_to_gpio usage Andrea Adami
@ 2013-08-09 20:44 ` Anton Vorontsov
0 siblings, 0 replies; 2+ messages in thread
From: Anton Vorontsov @ 2013-08-09 20:44 UTC (permalink / raw)
To: Andrea Adami; +Cc: linux-kernel, David Woodhouse, Russell King
On Sun, Jul 21, 2013 at 01:07:46AM +0200, Andrea Adami wrote:
> Fix
> linux/drivers/power/tosa_battery.c:153:2: error: implicit declaration of
> function 'irq_to_gpio' [-Werror=implicit-function-declaration]
> | pr_info("tosa_bat_gpio irq: %d\n",
> gpio_get_value(irq_to_gpio(irq)));
>
> as done for collie_battery.c with
> commit 629bcb4b72d49b3631ae3dd0fe1d345820fadfcc
>
> Since 9d08d5d77a355510c2f5657c86b0a4b25acfe72c, irq_to_gpio() is no
> longer available but still in use by collie_battery.c. As it's just
> for a debug message, just get rid of this call.
>
> Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> ---
Applied, thanks!
> drivers/power/tosa_battery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/tosa_battery.c b/drivers/power/tosa_battery.c
> index 0224de5..f4d80df 100644
> --- a/drivers/power/tosa_battery.c
> +++ b/drivers/power/tosa_battery.c
> @@ -150,7 +150,7 @@ static void tosa_bat_external_power_changed(struct power_supply *psy)
>
> static irqreturn_t tosa_bat_gpio_isr(int irq, void *data)
> {
> - pr_info("tosa_bat_gpio irq: %d\n", gpio_get_value(irq_to_gpio(irq)));
> + pr_info("tosa_bat_gpio irq\n");
> schedule_work(&bat_work);
> return IRQ_HANDLED;
> }
> --
> 1.8.1.5
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-09 20:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-20 23:07 [PATCH] power supply: tosa_battery: get rid of irq_to_gpio usage Andrea Adami
2013-08-09 20:44 ` Anton Vorontsov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®