* [PATCH] checkpatch: Fix networking kernel-doc block comment defect
[not found] ` <1374722064.3436.252.camel@dvhart-mobl1.amr.corp.intel.com>
@ 2013-07-25 3:31 ` Joe Perches
0 siblings, 0 replies; only message in thread
From: Joe Perches @ 2013-07-25 3:31 UTC (permalink / raw)
To: Andrew Morton, Darren Hart; +Cc: David Miller, netdev, LKML, Andy Whitcroft
checkpatch can generate a false positive when inserting
a new kernel-doc block and function above an existing
kernel-doc block.
Fix it by checking that the context line is also a newly
inserted line.
Reported-by: Darren Hart <dvhart@linux.intel.com>
Signed-off-by: Joe Perches <joe@perches.com>
---
scripts/checkpatch.pl | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 23126d4..c18e1be 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2074,6 +2074,7 @@ sub process {
if ($realfile =~ m@^(drivers/net/|net/)@ &&
$prevrawline =~ /^\+[ \t]*\/\*/ && #starting /*
$prevrawline !~ /\*\/[ \t]*$/ && #no trailing */
+ $rawline =~ /^\+/ && #line is new
$rawline !~ /^\+[ \t]*\*/) { #no leading *
WARN("NETWORKING_BLOCK_COMMENT_STYLE",
"networking block comments start with * on subsequent lines\n" . $hereprev);
--
1.8.1.2.459.gbcd45b4.dirty
^ permalink raw reply [flat|nested] only message in thread