* [PATCH] mfd: wm831x: Remove erronious bits per word set
@ 2013-07-30 12:19 Mark Brown
2013-07-31 9:40 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2013-07-30 12:19 UTC (permalink / raw)
To: Samuel Ortiz, Lee Jones; +Cc: patches, linux-kernel, Mark Brown
From: Mark Brown <broonie@linaro.org>
Since the conversion to the regmap API setting bits per word will lead to
data corruption since the regmap API already configures the bits per word
appropriately.
Signed-off-by: Mark Brown <broonie@linaro.org>
---
drivers/mfd/wm831x-spi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/wm831x-spi.c b/drivers/mfd/wm831x-spi.c
index e7ed14f66..07de3cc 100644
--- a/drivers/mfd/wm831x-spi.c
+++ b/drivers/mfd/wm831x-spi.c
@@ -34,7 +34,6 @@ static int wm831x_spi_probe(struct spi_device *spi)
if (wm831x == NULL)
return -ENOMEM;
- spi->bits_per_word = 16;
spi->mode = SPI_MODE_0;
spi_set_drvdata(spi, wm831x);
--
1.8.3.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: wm831x: Remove erronious bits per word set
2013-07-30 12:19 [PATCH] mfd: wm831x: Remove erronious bits per word set Mark Brown
@ 2013-07-31 9:40 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2013-07-31 9:40 UTC (permalink / raw)
To: Mark Brown; +Cc: Samuel Ortiz, patches, linux-kernel, Mark Brown
> From: Mark Brown <broonie@linaro.org>
>
> Since the conversion to the regmap API setting bits per word will lead to
> data corruption since the regmap API already configures the bits per word
> appropriately.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
> drivers/mfd/wm831x-spi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mfd/wm831x-spi.c b/drivers/mfd/wm831x-spi.c
Applied, thanks Mark.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-31 9:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-30 12:19 [PATCH] mfd: wm831x: Remove erronious bits per word set Mark Brown
2013-07-31 9:40 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®