mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 3.11-rc3+] radeon: si_dpm: Fix 32 bit __divdi3 modpost failure
@ 2013-08-01 15:25 Tim Gardner
  2013-08-01 15:51 ` Deucher, Alexander
  0 siblings, 1 reply; 2+ messages in thread
From: Tim Gardner @ 2013-08-01 15:25 UTC (permalink / raw)
  To: dri-devel, linux-kernel; +Cc: Tim Gardner, David Airlie, Alex Deucher

ERROR: "__divdi3" [drivers/gpu/drm/radeon/radeon.ko] undefined!
make[3]: *** [__modpost] Error 1

gcc version 4.8.1

Cc: David Airlie <airlied@linux.ie>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
 drivers/gpu/drm/radeon/si_dpm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/radeon/si_dpm.c b/drivers/gpu/drm/radeon/si_dpm.c
index 7ad22e87..4182557 100644
--- a/drivers/gpu/drm/radeon/si_dpm.c
+++ b/drivers/gpu/drm/radeon/si_dpm.c
@@ -1767,7 +1767,7 @@ static void si_calculate_leakage_for_v_and_t_formula(const struct ni_leakage_coe
 	s64 temperature, t_slope, t_intercept, av, bv, t_ref;
 	s64 tmp;
 
-	i_leakage = drm_int2fixp(ileakage) / 100;
+	i_leakage = div64_s64(drm_int2fixp(ileakage), 100);
 	vddc = div64_s64(drm_int2fixp(v), 1000);
 	temperature = div64_s64(drm_int2fixp(t), 1000);
 
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [PATCH 3.11-rc3+] radeon: si_dpm: Fix 32 bit __divdi3 modpost failure
  2013-08-01 15:25 [PATCH 3.11-rc3+] radeon: si_dpm: Fix 32 bit __divdi3 modpost failure Tim Gardner
@ 2013-08-01 15:51 ` Deucher, Alexander
  0 siblings, 0 replies; 2+ messages in thread
From: Deucher, Alexander @ 2013-08-01 15:51 UTC (permalink / raw)
  To: Tim Gardner, dri-devel, linux-kernel; +Cc: David Airlie

I've already got the fix queued in my -fixes branch:
http://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-fixes-3.11&id=1d2867b98372929129c7f2ce2c83a9b446a1b43a


> -----Original Message-----
> From: Tim Gardner [mailto:tim.gardner@canonical.com]
> Sent: Thursday, August 01, 2013 11:26 AM
> To: dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org
> Cc: Tim Gardner; David Airlie; Deucher, Alexander
> Subject: [PATCH 3.11-rc3+] radeon: si_dpm: Fix 32 bit __divdi3 modpost
> failure
> 
> ERROR: "__divdi3" [drivers/gpu/drm/radeon/radeon.ko] undefined!
> make[3]: *** [__modpost] Error 1
> 
> gcc version 4.8.1
> 
> Cc: David Airlie <airlied@linux.ie>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> ---
>  drivers/gpu/drm/radeon/si_dpm.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/radeon/si_dpm.c
> b/drivers/gpu/drm/radeon/si_dpm.c
> index 7ad22e87..4182557 100644
> --- a/drivers/gpu/drm/radeon/si_dpm.c
> +++ b/drivers/gpu/drm/radeon/si_dpm.c
> @@ -1767,7 +1767,7 @@ static void
> si_calculate_leakage_for_v_and_t_formula(const struct ni_leakage_coe
>  	s64 temperature, t_slope, t_intercept, av, bv, t_ref;
>  	s64 tmp;
> 
> -	i_leakage = drm_int2fixp(ileakage) / 100;
> +	i_leakage = div64_s64(drm_int2fixp(ileakage), 100);
>  	vddc = div64_s64(drm_int2fixp(v), 1000);
>  	temperature = div64_s64(drm_int2fixp(t), 1000);
> 
> --
> 1.7.9.5
> 



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-08-01 15:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-01 15:25 [PATCH 3.11-rc3+] radeon: si_dpm: Fix 32 bit __divdi3 modpost failure Tim Gardner
2013-08-01 15:51 ` Deucher, Alexander

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®