[PATCH] pktcdvd: Fix defective misuses of pkt_<level>

[PATCH] pktcdvd: Fix defective misuses of pkt_<level>

[Joe Perches]

Fix thinkos where pkt_<level> needs a valid
pktcdvd_device * and the pointer is known to
be NULL.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com> (go smatch!)
Signed-off-by: Joe Perches <joe@perches.com>
---

Andrew, I believe Jiri picked up this series and
you can drop them from mm.  Thanks.

 drivers/block/pktcdvd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index 29a5194..5618847 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -2360,8 +2360,8 @@ static void pkt_make_request(struct request_queue *q, struct bio *bio)
 
 	pd = q->queuedata;
 	if (!pd) {
-		pkt_err(pd, "%s incorrect request queue\n",
-			bdevname(bio->bi_bdev, b));
+		pr_err("%s incorrect request queue\n",
+		       bdevname(bio->bi_bdev, b));
 		goto end_io;
 	}
 
@@ -2841,7 +2841,7 @@ static int pkt_remove_dev(dev_t pkt_dev)
 			break;
 	}
 	if (idx == MAX_WRITERS) {
-		pkt_dbg(1, pd, "dev not setup\n");
+		pr_debug("dev not setup\n");
 		ret = -ENXIO;
 		goto out;
 	}

Re: [PATCH] pktcdvd: Fix defective misuses of pkt_<level>

[Andrew Morton]

On Fri, 02 Aug 2013 13:10:54 -0700 Joe Perches <joe@perches.com> wrote:

> Andrew, I believe Jiri picked up this series and
> you can drop them from mm.  Thanks.

Shall do if/when they turn up in linux-next.

Re: [PATCH] pktcdvd: Fix defective misuses of pkt_<level>

[Jiri Kosina]

On Tue, 6 Aug 2013, Andrew Morton wrote:

> > Andrew, I believe Jiri picked up this series and
> > you can drop them from mm.  Thanks.
> 
> Shall do if/when they turn up in linux-next.

Pull request to Jens is there [1], but his branch has been silent for two 
weeks ...

[1] https://lkml.org/lkml/2013/7/30/277

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH] pktcdvd: Fix defective misuses of pkt_<level>

[Jiri Kosina]

On Wed, 7 Aug 2013, Jiri Kosina wrote:

> > > Andrew, I believe Jiri picked up this series and
> > > you can drop them from mm.  Thanks.
> > 
> > Shall do if/when they turn up in linux-next.
> 
> Pull request to Jens is there [1], but his branch has been silent for two 
> weeks ...
> 
> [1] https://lkml.org/lkml/2013/7/30/277

And here goes a friendly ping to Jens ... ? :)

Thanks,

-- 
Jiri Kosina
SUSE Labs