mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Z Lam <azl@google.com>
To: Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org
Cc: Alexander Z Lam <azl@google.com>,
	David Sharp <dhsharp@google.com>,
	Vaibhav Nagarnaik <vnagarnaik@google.com>,
	Alexander Z Lam <lambchop468@gmail.com>
Subject: [PATCH 1/3] tracing: Make TRACE_ITER_STOP_ON_FREE stop the correct buffer
Date: Fri,  2 Aug 2013 18:36:15 -0700	[thread overview]
Message-ID: <1375493777-17261-1-git-send-email-azl@google.com> (raw)

Releasing the free_buffer file in an instance causes the global buffer
to be stopped when TRACE_ITER_STOP_ON_FREE is enabled. Operate on the
correct buffer.

Cc: Vaibhav Nagarnaik <vnagarnaik@google.com>
Cc: David Sharp <dhsharp@google.com>
Cc: Alexander Z Lam <lambchop468@gmail.com>
Signed-off-by: Alexander Z Lam <azl@google.com>
---
 kernel/trace/trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 882ec1d..9bfb889 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -4468,7 +4468,7 @@ tracing_free_buffer_release(struct inode *inode, struct file *filp)
 
 	/* disable tracing ? */
 	if (trace_flags & TRACE_ITER_STOP_ON_FREE)
-		tracing_off();
+		tracer_tracing_off(tr);
 	/* resize the ring buffer to 0 */
 	tracing_resize_ring_buffer(tr, 0, RING_BUFFER_ALL_CPUS);
 
-- 
1.8.3


             reply	other threads:[~2013-08-03  1:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-03  1:36 Alexander Z Lam [this message]
2013-08-03  1:36 ` [PATCH 2/3] tracing: Fix reset of time stamps during trace_clock changes Alexander Z Lam
2013-08-03  1:53   ` Steven Rostedt
2013-08-03  1:36 ` [PATCH 3/3] tracing: Make tracing_cpumask available for all instances Alexander Z Lam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375493777-17261-1-git-send-email-azl@google.com \
    --to=azl@google.com \
    --cc=dhsharp@google.com \
    --cc=lambchop468@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=vnagarnaik@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®