From: Steven Rostedt <rostedt@goodmis.org>
To: Alexander Z Lam <azl@google.com>
Cc: linux-kernel@vger.kernel.org, David Sharp <dhsharp@google.com>,
Vaibhav Nagarnaik <vnagarnaik@google.com>,
Alexander Z Lam <lambchop468@gmail.com>
Subject: Re: [PATCH 2/3] tracing: Fix reset of time stamps during trace_clock changes
Date: Fri, 02 Aug 2013 21:53:43 -0400 [thread overview]
Message-ID: <1375494823.22073.37.camel@gandalf.local.home> (raw)
In-Reply-To: <1375493777-17261-2-git-send-email-azl@google.com>
On Fri, 2013-08-02 at 18:36 -0700, Alexander Z Lam wrote:
> Fixed two issues with changing the timestamp clock with trace_clock:
>
> - The global buffer was reset on instance clock changes. Change this to pass
> the correct per-instance buffer
> - ftrace_now() is used to set buf->time_start in tracing_reset_online_cpus().
> This was incorrect because ftrace_now() used the global buffer's clock to
> return the current time. Change this to use buffer_ftrace_now() which
> returns the current time for the correct per-instance buffer.
The first two patches look to go into 3.11 and 3.10 stable. The removal
below is not urgent, but I can keep it in this patch.
>
> Also removed tracing_reset_current() because it is not used anywhere
>
The third patch can wait to 3.12. I'll review it later.
Thanks,
-- Steve
next prev parent reply other threads:[~2013-08-03 1:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-03 1:36 [PATCH 1/3] tracing: Make TRACE_ITER_STOP_ON_FREE stop the correct buffer Alexander Z Lam
2013-08-03 1:36 ` [PATCH 2/3] tracing: Fix reset of time stamps during trace_clock changes Alexander Z Lam
2013-08-03 1:53 ` Steven Rostedt [this message]
2013-08-03 1:36 ` [PATCH 3/3] tracing: Make tracing_cpumask available for all instances Alexander Z Lam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375494823.22073.37.camel@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=azl@google.com \
--cc=dhsharp@google.com \
--cc=lambchop468@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vnagarnaik@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®