From: "Nicholas A. Bellinger" <nab@daterainc.com>
To: target-devel <target-devel@vger.kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
Martin Petersen <martin.petersen@oracle.com>,
Chris Mason <chris.mason@fusionio.com>,
Roland Dreier <roland@purestorage.com>,
James Bottomley <JBottomley@Parallels.com>,
Nicholas Bellinger <nab@linux-iscsi.org>,
Nicholas Bellinger <nab@daterainc.com>
Subject: [PATCH-v2 03/12] target: Add TCM_MISCOMPARE_VERIFY sense handling
Date: Thu, 22 Aug 2013 04:54:01 +0000 [thread overview]
Message-ID: <1377147250-10125-4-git-send-email-nab@daterainc.com> (raw)
In-Reply-To: <1377147250-10125-1-git-send-email-nab@daterainc.com>
From: Nicholas Bellinger <nab@daterainc.com>
This patch adds TCM_MISCOMPARE_VERIFY (ASC=0x1d, ASCQ=0x00) sense
handling to transport_send_check_condition_and_sense(), which is
required for a COMPARE_AND_WRITE comparision failure.
Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Martin Petersen <martin.petersen@oracle.com>
Cc: Chris Mason <chris.mason@fusionio.com>
Cc: James Bottomley <JBottomley@Parallels.com>
Cc: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Nicholas Bellinger <nab@daterainc.com>
---
drivers/target/target_core_transport.c | 9 +++++++++
include/target/target_core_base.h | 1 +
2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index 53d1d75..3d3dc97 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -2791,6 +2791,15 @@ transport_send_check_condition_and_sense(struct se_cmd *cmd,
buffer[SPC_ASC_KEY_OFFSET] = asc;
buffer[SPC_ASCQ_KEY_OFFSET] = ascq;
break;
+ case TCM_MISCOMPARE_VERIFY:
+ /* CURRENT ERROR */
+ buffer[0] = 0x70;
+ buffer[SPC_ADD_SENSE_LEN_OFFSET] = 10;
+ buffer[SPC_SENSE_KEY_OFFSET] = MISCOMPARE;
+ /* MISCOMPARE DURING VERIFY OPERATION */
+ buffer[SPC_ASC_KEY_OFFSET] = 0x1d;
+ buffer[SPC_ASCQ_KEY_OFFSET] = 0x00;
+ break;
case TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE:
default:
/* CURRENT ERROR */
diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h
index 6e946f3..fac25c5 100644
--- a/include/target/target_core_base.h
+++ b/include/target/target_core_base.h
@@ -197,6 +197,7 @@ enum tcm_sense_reason_table {
TCM_ADDRESS_OUT_OF_RANGE = R(0x11),
TCM_OUT_OF_RESOURCES = R(0x12),
TCM_PARAMETER_LIST_LENGTH_ERROR = R(0x13),
+ TCM_MISCOMPARE_VERIFY = R(0x14),
#undef R
};
--
1.7.2.5
next prev parent reply other threads:[~2013-08-22 5:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 4:53 [PATCH-v2 00/12] target: Add support for COMPARE_AND_WRITE (VAAI) emulation Nicholas A. Bellinger
2013-08-22 4:53 ` [PATCH-v2 01/12] scsi: Add CDB definition for COMPARE_AND_WRITE Nicholas A. Bellinger
2013-08-22 4:54 ` [PATCH-v2 02/12] target: Add return for se_cmd->transport_complete_callback Nicholas A. Bellinger
2013-08-22 4:54 ` Nicholas A. Bellinger [this message]
2013-08-22 4:54 ` [PATCH-v2 04/12] target: Allow sbc_ops->execute_rw() to accept SGLs + data_direction Nicholas A. Bellinger
2013-08-22 4:54 ` [PATCH-v2 05/12] target: Convert se_cmd->t_bidi_data_sg checks to use SCF_BIDI Nicholas A. Bellinger
2013-08-22 4:54 ` [PATCH-v2 06/12] target: Add memory allocation for bidirectional commands Nicholas A. Bellinger
2013-08-24 15:18 ` Christoph Hellwig
2013-08-24 23:44 ` Nicholas A. Bellinger
2013-08-22 4:54 ` [PATCH-v2 07/12] target: Add transport_reset_sgl_orig() for COMPARE_AND_WRITE Nicholas A. Bellinger
2013-08-22 4:54 ` [PATCH-v2 08/12] target: Make __target_execute_cmd() available as extern Nicholas A. Bellinger
2013-08-22 4:54 ` [PATCH-v2 09/12] target: Add MAXIMUM COMPARE AND WRITE LENGTH in Block Limits VPD Nicholas A. Bellinger
2013-08-22 4:54 ` [PATCH-v2 10/12] target: Add support for COMPARE_AND_WRITE emulation Nicholas A. Bellinger
2013-08-22 4:54 ` [PATCH-v2 11/12] target: Add compare_and_write_post() completion callback fall through Nicholas A. Bellinger
2013-08-22 4:54 ` [PATCH-v2 12/12] target: Release COMPARE_AND_WRITE mutex in generic failure path Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377147250-10125-4-git-send-email-nab@daterainc.com \
--to=nab@daterainc.com \
--cc=JBottomley@Parallels.com \
--cc=chris.mason@fusionio.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nab@linux-iscsi.org \
--cc=roland@purestorage.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®