From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Nicholas A. Bellinger" <nab@daterainc.com>,
target-devel <target-devel@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
Martin Petersen <martin.petersen@oracle.com>,
Chris Mason <chris.mason@fusionio.com>,
Roland Dreier <roland@purestorage.com>,
James Bottomley <JBottomley@Parallels.com>
Subject: Re: [PATCH-v2 06/12] target: Add memory allocation for bidirectional commands
Date: Sat, 24 Aug 2013 16:44:05 -0700 [thread overview]
Message-ID: <1377387845.32763.149.camel@haakon3.risingtidesystems.com> (raw)
In-Reply-To: <20130824151817.GA15588@infradead.org>
On Sat, 2013-08-24 at 08:18 -0700, Christoph Hellwig wrote:
> > static int
> > +transport_generic_get_mem_bidi(struct se_cmd *cmd)
>
> Except for the fields touched in struct se_cmd this is a duplication
> of transport_generic_get_mem. I'd suggest to factor that one into
> a new helper:
>
> static int
> target_alloc_sgl(struct scatterlist **sgl, unsigned int **nents,
> u32 length, gfp_t gfp_mask)
> {
> ..
> }
>
> and then call that one from transport_generic_new_cmd directly,
Sounds reasonable enough, doing that bit of refactoring now..
> including opencoding the actual BIDI case there as a first step.
>
Not sure why this needs to be opencoded for BIDI, instead of just doing
target_alloc_sgl(&cmd->t_bidi_data_sg, ...) for the two SCF_BIDI ||
SCF_COMPARE_AND_WRITE cases in transport_generic_new_cmd()..?
--nab
next prev parent reply other threads:[~2013-08-24 23:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 4:53 [PATCH-v2 00/12] target: Add support for COMPARE_AND_WRITE (VAAI) emulation Nicholas A. Bellinger
2013-08-22 4:53 ` [PATCH-v2 01/12] scsi: Add CDB definition for COMPARE_AND_WRITE Nicholas A. Bellinger
2013-08-22 4:54 ` [PATCH-v2 02/12] target: Add return for se_cmd->transport_complete_callback Nicholas A. Bellinger
2013-08-22 4:54 ` [PATCH-v2 03/12] target: Add TCM_MISCOMPARE_VERIFY sense handling Nicholas A. Bellinger
2013-08-22 4:54 ` [PATCH-v2 04/12] target: Allow sbc_ops->execute_rw() to accept SGLs + data_direction Nicholas A. Bellinger
2013-08-22 4:54 ` [PATCH-v2 05/12] target: Convert se_cmd->t_bidi_data_sg checks to use SCF_BIDI Nicholas A. Bellinger
2013-08-22 4:54 ` [PATCH-v2 06/12] target: Add memory allocation for bidirectional commands Nicholas A. Bellinger
2013-08-24 15:18 ` Christoph Hellwig
2013-08-24 23:44 ` Nicholas A. Bellinger [this message]
2013-08-22 4:54 ` [PATCH-v2 07/12] target: Add transport_reset_sgl_orig() for COMPARE_AND_WRITE Nicholas A. Bellinger
2013-08-22 4:54 ` [PATCH-v2 08/12] target: Make __target_execute_cmd() available as extern Nicholas A. Bellinger
2013-08-22 4:54 ` [PATCH-v2 09/12] target: Add MAXIMUM COMPARE AND WRITE LENGTH in Block Limits VPD Nicholas A. Bellinger
2013-08-22 4:54 ` [PATCH-v2 10/12] target: Add support for COMPARE_AND_WRITE emulation Nicholas A. Bellinger
2013-08-22 4:54 ` [PATCH-v2 11/12] target: Add compare_and_write_post() completion callback fall through Nicholas A. Bellinger
2013-08-22 4:54 ` [PATCH-v2 12/12] target: Release COMPARE_AND_WRITE mutex in generic failure path Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377387845.32763.149.camel@haakon3.risingtidesystems.com \
--to=nab@linux-iscsi.org \
--cc=JBottomley@Parallels.com \
--cc=chris.mason@fusionio.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nab@daterainc.com \
--cc=roland@purestorage.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®