mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [v2 PATCH 1/3] staging: ozwpan: Increase ISOC IN buffer depth
@ 2013-08-28 11:43 Rupesh Gujare
  2013-08-28 11:43 ` [v2 PATCH 2/3] staging: ozwpan: Change error number Rupesh Gujare
  2013-08-28 11:43 ` [v2 PATCH 3/3] staging: ozwpan: Return error, if PD is not connected Rupesh Gujare
  0 siblings, 2 replies; 3+ messages in thread
From: Rupesh Gujare @ 2013-08-28 11:43 UTC (permalink / raw)
  To: devel; +Cc: dan.carpenter, sergei.shtylyov, linux-usb, linux-kernel, gregkh

Buffer depth of 50 units is not sufficient when there is considerable delay
occuring on air due to interference, increase ISOC IN buffer depth to 100 units.

Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
---
 drivers/staging/ozwpan/ozhcd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index d6c3d0e..d9c43c3 100644
--- a/drivers/staging/ozwpan/ozhcd.c
+++ b/drivers/staging/ozwpan/ozhcd.c
@@ -39,7 +39,7 @@
  * Number of units of buffering to capture for an isochronous IN endpoint before
  * allowing data to be indicated up.
  */
-#define OZ_IN_BUFFERING_UNITS	50
+#define OZ_IN_BUFFERING_UNITS	100
 
 /* Name of our platform device.
  */
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [v2 PATCH 2/3] staging: ozwpan: Change error number.
  2013-08-28 11:43 [v2 PATCH 1/3] staging: ozwpan: Increase ISOC IN buffer depth Rupesh Gujare
@ 2013-08-28 11:43 ` Rupesh Gujare
  2013-08-28 11:43 ` [v2 PATCH 3/3] staging: ozwpan: Return error, if PD is not connected Rupesh Gujare
  1 sibling, 0 replies; 3+ messages in thread
From: Rupesh Gujare @ 2013-08-28 11:43 UTC (permalink / raw)
  To: devel; +Cc: dan.carpenter, sergei.shtylyov, linux-usb, linux-kernel, gregkh

Incorrect error number was returned here (EPERM), ENXIO is more
appropriate.

Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
---
 drivers/staging/ozwpan/ozcdev.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c
index 03b41ee..50722ea 100644
--- a/drivers/staging/ozwpan/ozcdev.c
+++ b/drivers/staging/ozwpan/ozcdev.c
@@ -161,7 +161,7 @@ static ssize_t oz_cdev_write(struct file *filp, const char __user *buf,
 		oz_pd_get(pd);
 	spin_unlock_bh(&g_cdev.lock);
 	if (pd == NULL)
-		return -1;
+		return -ENXIO;
 	eb = &pd->elt_buff;
 	ei = oz_elt_info_alloc(eb);
 	if (ei == NULL) {
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [v2 PATCH 3/3] staging: ozwpan: Return error, if PD is not connected.
  2013-08-28 11:43 [v2 PATCH 1/3] staging: ozwpan: Increase ISOC IN buffer depth Rupesh Gujare
  2013-08-28 11:43 ` [v2 PATCH 2/3] staging: ozwpan: Change error number Rupesh Gujare
@ 2013-08-28 11:43 ` Rupesh Gujare
  1 sibling, 0 replies; 3+ messages in thread
From: Rupesh Gujare @ 2013-08-28 11:43 UTC (permalink / raw)
  To: devel; +Cc: dan.carpenter, sergei.shtylyov, linux-usb, linux-kernel, gregkh

Return error if we receive write(), while PD is not connected.

Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
---
 drivers/staging/ozwpan/ozcdev.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c
index 50722ea..6ccb64f 100644
--- a/drivers/staging/ozwpan/ozcdev.c
+++ b/drivers/staging/ozwpan/ozcdev.c
@@ -162,6 +162,8 @@ static ssize_t oz_cdev_write(struct file *filp, const char __user *buf,
 	spin_unlock_bh(&g_cdev.lock);
 	if (pd == NULL)
 		return -ENXIO;
+	if (!(pd->state & OZ_PD_S_CONNECTED))
+		return -EAGAIN;
 	eb = &pd->elt_buff;
 	ei = oz_elt_info_alloc(eb);
 	if (ei == NULL) {
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-08-28 11:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-28 11:43 [v2 PATCH 1/3] staging: ozwpan: Increase ISOC IN buffer depth Rupesh Gujare
2013-08-28 11:43 ` [v2 PATCH 2/3] staging: ozwpan: Change error number Rupesh Gujare
2013-08-28 11:43 ` [v2 PATCH 3/3] staging: ozwpan: Return error, if PD is not connected Rupesh Gujare

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®