* [checkpatch.pl] runtime error by version dependency.
@ 2013-09-09 12:16 Tetsuo Handa
2013-09-09 15:49 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Tetsuo Handa @ 2013-09-09 12:16 UTC (permalink / raw)
To: joe; +Cc: bruce.w.allan, linux-kernel
Hello.
Commit d1fe9c09 "checkpatch: add some --strict coding style checks"
introduced dependency on perl >= 5.10.0 .
While the comment says that "Any use must be runtime checked with $^V",
it is not runtime checked when running with perl == v5.8.4 , failing with
Nested quantifiers in regex; marked by <-- HERE in m/(\((?:[^\(\)]++ <-- HERE |(?-1))*\))/ at ./scripts/checkpatch.pl line 340.
error.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [checkpatch.pl] runtime error by version dependency.
2013-09-09 12:16 [checkpatch.pl] runtime error by version dependency Tetsuo Handa
@ 2013-09-09 15:49 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2013-09-09 15:49 UTC (permalink / raw)
To: Tetsuo Handa, Dave Hansen; +Cc: bruce.w.allan, linux-kernel
On Mon, 2013-09-09 at 21:16 +0900, Tetsuo Handa wrote:
> Hello.
>
> Commit d1fe9c09 "checkpatch: add some --strict coding style checks"
> introduced dependency on perl >= 5.10.0 .
>
> While the comment says that "Any use must be runtime checked with $^V",
> it is not runtime checked when running with perl == v5.8.4 , failing with
>
> Nested quantifiers in regex; marked by <-- HERE in m/(\((?:[^\(\)]++ <-- HERE |(?-1))*\))/ at ./scripts/checkpatch.pl line 340.
>
> error.
Hello.
See Dave Hansen's commit fab4a18a0d2bb0b90e51a945886397f1de9cb6d4
("enforce sane perl version")
[PATCH] checkpatch: enforce sane perl version
I got a bug report from a couple of users who said checkpatch.pl was
broken for them. It was erroring out on fairly random lines most commonly
with messages like:
Nested quantifiers in regex; marked by <--HERE in m/(\((?:[^\(\)]++ <-- HERE |(?-1))*\))/ at ./checkpatch.pl line 340.
The bug reporter was running a version of perl 5.8 which was end-of-lifed
in 2008: http://www.cpan.org/src/. Versions of perl this old are at
_best_ quite untested. At worst, they are crusty and known to be
completely broken.
If folks have a system _that_ old, then we should have mercy on them and
give them a half-decent error message rather than fail with nutty error
messages.
This patch enforces that checkpatch.pl is run with perl 5.10, which was
end-of-lifed in 2009. The new --ignore-perl-version command-line switch
will let folks override this if they want.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-09 15:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-09 12:16 [checkpatch.pl] runtime error by version dependency Tetsuo Handa
2013-09-09 15:49 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®