From: Libin <huawei.libin@huawei.com>
To: <tj@kernel.org>, <tglx@linutronix.de>
Cc: <linux-kernel@vger.kernel.org>, <akpm@linux-foundation.org>,
<mingo@redhat.com>, <wangyijing@huawei.com>,
<guohanjun@huawei.com>, <huawei.libin@huawei.com>
Subject: [PATCH] workqueue: remove redundant timer_stats_timer_set_start_info() call
Date: Tue, 10 Sep 2013 14:35:27 +0800 [thread overview]
Message-ID: <1378794927-4396-1-git-send-email-huawei.libin@huawei.com> (raw)
From: Li Bin <huawei.libin@huawei.com>
There is a redundant call for timer_stats_timer_set_start_info(),
because it is the responsibility of the 'timer add' function:
add_timer_on()
|- timer_stats_timer_set_start_info()
add_timer()
|- mod_timer()
|- __mod_timer()
|- timer_stats_timer_set_start_info()
So the calling here is redundant, remove it.
Signed-off-by: Li Bin <huawei.libin@huawei.com>
---
kernel/workqueue.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 987293d..51ca50e 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -1462,8 +1462,6 @@ static void __queue_delayed_work(int cpu, struct workqueue_struct *wq,
return;
}
- timer_stats_timer_set_start_info(&dwork->timer);
-
dwork->wq = wq;
dwork->cpu = cpu;
timer->expires = jiffies + delay;
--
1.8.2.1
next reply other threads:[~2013-09-10 6:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 6:35 Libin [this message]
2013-09-10 13:45 ` Tejun Heo
2013-09-11 0:49 ` Libin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378794927-4396-1-git-send-email-huawei.libin@huawei.com \
--to=huawei.libin@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=guohanjun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=wangyijing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®