From: Libin <huawei.libin@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: <tglx@linutronix.de>, <linux-kernel@vger.kernel.org>,
<akpm@linux-foundation.org>, <mingo@redhat.com>,
<wangyijing@huawei.com>, <guohanjun@huawei.com>
Subject: Re: [PATCH] workqueue: remove redundant timer_stats_timer_set_start_info() call
Date: Wed, 11 Sep 2013 08:49:34 +0800 [thread overview]
Message-ID: <522FBE1E.4020208@huawei.com> (raw)
In-Reply-To: <20130910134533.GB7275@htj.dyndns.org>
On 2013/9/10 21:45, Tejun Heo wrote:
> On Tue, Sep 10, 2013 at 02:35:27PM +0800, Libin wrote:
>> From: Li Bin <huawei.libin@huawei.com>
>>
>> There is a redundant call for timer_stats_timer_set_start_info(),
>> because it is the responsibility of the 'timer add' function:
>>
>> add_timer_on()
>> |- timer_stats_timer_set_start_info()
>>
>> add_timer()
>> |- mod_timer()
>> |- __mod_timer()
>> |- timer_stats_timer_set_start_info()
>>
>> So the calling here is redundant, remove it.
>
> I think it's intentional to record the caller's address so that timers
> from delayed_work items can be distinguished.
>
Indeed the case, thank you tejun.
Libin
> Thanks.
>
prev parent reply other threads:[~2013-09-11 0:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 6:35 Libin
2013-09-10 13:45 ` Tejun Heo
2013-09-11 0:49 ` Libin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522FBE1E.4020208@huawei.com \
--to=huawei.libin@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=guohanjun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=wangyijing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®