* [PATCH] mei: me: downgrade "suspend" message to debug level
@ 2013-09-12 19:17 Paul Bolle
2013-09-12 19:31 ` Paul Bolle
0 siblings, 1 reply; 6+ messages in thread
From: Paul Bolle @ 2013-09-12 19:17 UTC (permalink / raw)
To: Tomas Winkler; +Cc: linux-kernel
The mei_me driver prints "suspend" at error level at each suspend.
Downgrade that uninteresting message to debug level.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Lightly tested (on top of v3.10.10, actually). Should apply cleanly to
v3.11 or current master.
Perhaps a better fix is to remove this message entirely.
drivers/misc/mei/pci-me.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
index 0f26832..02740fc 100644
--- a/drivers/misc/mei/pci-me.c
+++ b/drivers/misc/mei/pci-me.c
@@ -281,7 +281,7 @@ static int mei_me_pci_suspend(struct device *device)
if (!dev)
return -ENODEV;
- dev_err(&pdev->dev, "suspend\n");
+ dev_dbg(&pdev->dev, "suspend\n");
mei_stop(dev);
--
1.8.1.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mei: me: downgrade "suspend" message to debug level
2013-09-12 19:17 [PATCH] mei: me: downgrade "suspend" message to debug level Paul Bolle
@ 2013-09-12 19:31 ` Paul Bolle
2013-09-13 9:12 ` Winkler, Tomas
0 siblings, 1 reply; 6+ messages in thread
From: Paul Bolle @ 2013-09-12 19:31 UTC (permalink / raw)
To: Tomas Winkler; +Cc: linux-kernel
On Thu, 2013-09-12 at 21:17 +0200, Paul Bolle wrote:
> The mei_me driver prints "suspend" at error level at each suspend.
> Downgrade that uninteresting message to debug level.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Lightly tested (on top of v3.10.10, actually). Should apply cleanly to
> v3.11 or current master.
>
> Perhaps a better fix is to remove this message entirely.
Rechecking my logs I noticed a "stop" error on module unload. That
message could be downgraded to debug level too. But it could also be
removed. If Tomas could say what is preferable I'll send a second
version of this trivial patch.
Paul Bolle
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] mei: me: downgrade "suspend" message to debug level
2013-09-12 19:31 ` Paul Bolle
@ 2013-09-13 9:12 ` Winkler, Tomas
2013-09-19 10:17 ` [PATCH v2] mei: me: downgrade two errors " Paul Bolle
0 siblings, 1 reply; 6+ messages in thread
From: Winkler, Tomas @ 2013-09-13 9:12 UTC (permalink / raw)
To: Paul Bolle; +Cc: linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 691 bytes --]
> >
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > ---
> > Lightly tested (on top of v3.10.10, actually). Should apply cleanly to
> > v3.11 or current master.
> >
> > Perhaps a better fix is to remove this message entirely.
>
> Rechecking my logs I noticed a "stop" error on module unload. That
> message could be downgraded to debug level too. But it could also be
> removed. If Tomas could say what is preferable I'll send a second
> version of this trivial patch.
I prefer to have it on debug level.
Thanks
Tomas
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2] mei: me: downgrade two errors to debug level
2013-09-13 9:12 ` Winkler, Tomas
@ 2013-09-19 10:17 ` Paul Bolle
2013-09-26 8:56 ` Tomas Winkler
0 siblings, 1 reply; 6+ messages in thread
From: Paul Bolle @ 2013-09-19 10:17 UTC (permalink / raw)
To: Tomas Winkler; +Cc: Adam Jackson, Joe Perches, linux-kernel
The mei_me driver prints "suspend" at error level at each suspend. It
also prints "stop" at error level at driver unload. Downgrade these
uninteresting messages to debug level.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) v1 was called "mei: me: downgrade "suspend" message to debug level".
v2 also downgrades the "stop" message.
1) Added Adam and Joe to Cc:. They were involved in discussing a patch
by Adam, which was similar to my v1, about a week ago.
2) Still lightly tested only, but now on top of v3.11.1.
drivers/misc/mei/pci-me.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
index 1b3844e..897ee6b 100644
--- a/drivers/misc/mei/pci-me.c
+++ b/drivers/misc/mei/pci-me.c
@@ -231,7 +231,7 @@ static void mei_me_remove(struct pci_dev *pdev)
hw = to_me_hw(dev);
- dev_err(&pdev->dev, "stop\n");
+ dev_dbg(&pdev->dev, "stop\n");
mei_stop(dev);
/* disable interrupts */
@@ -262,7 +262,7 @@ static int mei_me_pci_suspend(struct device *device)
if (!dev)
return -ENODEV;
- dev_err(&pdev->dev, "suspend\n");
+ dev_dbg(&pdev->dev, "suspend\n");
mei_stop(dev);
--
1.8.1.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] mei: me: downgrade two errors to debug level
2013-09-19 10:17 ` [PATCH v2] mei: me: downgrade two errors " Paul Bolle
@ 2013-09-26 8:56 ` Tomas Winkler
2013-09-26 10:24 ` Paul Bolle
0 siblings, 1 reply; 6+ messages in thread
From: Tomas Winkler @ 2013-09-26 8:56 UTC (permalink / raw)
To: Paul Bolle; +Cc: Adam Jackson, Joe Perches, linux-kernel
On Thu, Sep 19, 2013 at 1:17 PM, Paul Bolle <pebolle@tiscali.nl> wrote:
> The mei_me driver prints "suspend" at error level at each suspend. It
> also prints "stop" at error level at driver unload. Downgrade these
> uninteresting messages to debug level.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) v1 was called "mei: me: downgrade "suspend" message to debug level".
> v2 also downgrades the "stop" message.
>
> 1) Added Adam and Joe to Cc:. They were involved in discussing a patch
> by Adam, which was similar to my v1, about a week ago.
>
> 2) Still lightly tested only, but now on top of v3.11.1.
>
> drivers/misc/mei/pci-me.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
> index 1b3844e..897ee6b 100644
> --- a/drivers/misc/mei/pci-me.c
> +++ b/drivers/misc/mei/pci-me.c
> @@ -231,7 +231,7 @@ static void mei_me_remove(struct pci_dev *pdev)
> hw = to_me_hw(dev);
>
>
> - dev_err(&pdev->dev, "stop\n");
> + dev_dbg(&pdev->dev, "stop\n");
> mei_stop(dev);
>
> /* disable interrupts */
> @@ -262,7 +262,7 @@ static int mei_me_pci_suspend(struct device *device)
> if (!dev)
> return -ENODEV;
>
> - dev_err(&pdev->dev, "suspend\n");
> + dev_dbg(&pdev->dev, "suspend\n");
>
> mei_stop(dev);
>
> --
> 1.8.1.4
Ack
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] mei: me: downgrade two errors to debug level
2013-09-26 8:56 ` Tomas Winkler
@ 2013-09-26 10:24 ` Paul Bolle
0 siblings, 0 replies; 6+ messages in thread
From: Paul Bolle @ 2013-09-26 10:24 UTC (permalink / raw)
To: Tomas Winkler; +Cc: Tomas Winkler, Adam Jackson, Joe Perches, linux-kernel
On Thu, 2013-09-26 at 11:56 +0300, Tomas Winkler wrote:
> On Thu, Sep 19, 2013 at 1:17 PM, Paul Bolle <pebolle@tiscali.nl> wrote:
> > The mei_me driver prints "suspend" at error level at each suspend. It
> > also prints "stop" at error level at driver unload. Downgrade these
> > uninteresting messages to debug level.
> >
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
>>[...]
>
> Ack
You're the same person as the Tomas Winkler with the intel.com address,
aren't you? If so, you're the maintainer of this code. That makes me
wonder what this Ack is supposed to mean.
Paul Bolle
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-26 10:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-12 19:17 [PATCH] mei: me: downgrade "suspend" message to debug level Paul Bolle
2013-09-12 19:31 ` Paul Bolle
2013-09-13 9:12 ` Winkler, Tomas
2013-09-19 10:17 ` [PATCH v2] mei: me: downgrade two errors " Paul Bolle
2013-09-26 8:56 ` Tomas Winkler
2013-09-26 10:24 ` Paul Bolle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®