From: Iker Pedrosa <ikerpedrosam@gmail.com>
To: pavel@ucw.cz
Cc: gregkh@linuxfoundation.org, ikerpedrosam@gmail.com,
harsh1kumar@gmail.com, dan.carpenter@oracle.com,
mujeeb.adil@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 08/24] Staging: winbond: reg: changed sleep function from msleep to usleep
Date: Mon, 16 Sep 2013 15:43:28 +0200 [thread overview]
Message-ID: <1379339024-12157-9-git-send-email-ikerpedrosam@gmail.com> (raw)
In-Reply-To: <1379339024-12157-1-git-send-email-ikerpedrosam@gmail.com>
According to the documentation it is not recommended to use msleep for 1ms - 20ms because it may sleep longer than 20ms. So, it is recommended to use usleep instead.
In the first revision Greg KH pointed out that this change broke the build. In my computer it builds properly so if someone has the same problem please copy the output so that I can figure out what is the problem.
Signed-off-by: Iker Pedrosa <ikerpedrosam@gmail.com>
---
drivers/staging/winbond/reg.c | 54 +++++++++++++++++++++----------------------
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
index 80b4b34..c023fda 100644
--- a/drivers/staging/winbond/reg.c
+++ b/drivers/staging/winbond/reg.c
@@ -890,9 +890,9 @@ void Uxx_power_on_procedure(struct hw_data *pHwData)
else {
Wb35Reg_WriteSync(pHwData, 0x03f4, 0xFF5807FF);
Wb35Reg_WriteSync(pHwData, 0x03d4, 0x80); /* regulator on only */
- msleep(10);
- Wb35Reg_WriteSync(pHwData, 0x03d4, 0xb8); /* REG_ON RF_RSTN on, and */
- msleep(10);
+ usleep(10000);
+ Wb35Reg_WriteSync(pHwData, 0x03d4, 0xb8); /* REG_ON RF_RSTN on */
+ usleep(10000);
ltmp = 0x4968;
if ((pHwData->phy_type == RF_WB_242) ||
(RF_WB_242_1 == pHwData->phy_type))
@@ -905,7 +905,7 @@ void Uxx_power_on_procedure(struct hw_data *pHwData)
Wb35Reg_ReadSync(pHwData, 0x03d0, <mp);
loop = 500; /* Wait for 5 second */
while (!(ltmp & 0x20) && loop--) {
- msleep(10);
+ usleep(10000);
if (!Wb35Reg_ReadSync(pHwData, 0x03d0, <mp))
break;
}
@@ -914,7 +914,7 @@ void Uxx_power_on_procedure(struct hw_data *pHwData)
}
Wb35Reg_WriteSync(pHwData, 0x03b0, 1); /* Reset hardware first */
- msleep(10);
+ usleep(10000);
/* Set burst write delay */
Wb35Reg_WriteSync(pHwData, 0x03f8, 0x7ff);
@@ -1055,18 +1055,18 @@ void RFSynthesizer_initial(struct hw_data *pHwData)
case RF_AIROHA_2230:
ltmp = (1 << 31) | (0 << 30) | (20 << 24) | BitReverse((0x07 << 20) | 0xE168E, 20);
Wb35Reg_WriteSync(pHwData, 0x0864, ltmp);
- msleep(10);
+ usleep(10000);
ltmp = (1 << 31) | (0 << 30) | (20 << 24) | BitReverse(al2230_rf_data[7], 20);
Wb35Reg_WriteSync(pHwData, 0x0864, ltmp);
- msleep(10);
+ usleep(10000);
case RF_AIROHA_2230S:
Wb35Reg_WriteSync(pHwData, 0x03d4, 0x80); /* regulator on only */
- msleep(10);
+ usleep(10000);
Wb35Reg_WriteSync(pHwData, 0x03d4, 0xa0); /* PLL_PD REF_PD set to 0 */
- msleep(10);
+ usleep(10000);
Wb35Reg_WriteSync(pHwData, 0x03d4, 0xe0); /* MLK_EN */
Wb35Reg_WriteSync(pHwData, 0x03b0, 1); /* Reset hardware first */
- msleep(10);
+ usleep(10000);
/* ========================================================= */
/* The follow code doesn't use the burst-write mode */
@@ -1077,15 +1077,15 @@ void RFSynthesizer_initial(struct hw_data *pHwData)
Wb35Reg_WriteSync(pHwData, 0x105c, ltmp);
pHwData->reg.BB50 |= 0x13; /* (MASK_IQCAL_MODE|MASK_CALIB_START) */
Wb35Reg_WriteSync(pHwData, 0x1050, pHwData->reg.BB50);
- msleep(5);
+ usleep(5000);
ltmp = (1 << 31) | (0 << 30) | (20 << 24) | BitReverse((0x0F << 20) | 0xF01B0, 20);
Wb35Reg_WriteSync(pHwData, 0x0864, ltmp);
- msleep(5);
+ usleep(5000);
ltmp = (1 << 31) | (0 << 30) | (20 << 24) | BitReverse((0x0F << 20) | 0xF01E0, 20);
Wb35Reg_WriteSync(pHwData, 0x0864, ltmp);
- msleep(5);
+ usleep(5000);
ltmp = (1 << 31) | (0 << 30) | (20 << 24) | BitReverse((0x0F << 20) | 0xF01A0, 20);
Wb35Reg_WriteSync(pHwData, 0x0864, ltmp);
@@ -1102,13 +1102,13 @@ void RFSynthesizer_initial(struct hw_data *pHwData)
/* 2.4GHz */
ltmp = (1 << 31) | (0 << 30) | (24 << 24) | 0x9ABA8F;
Wb35Reg_WriteSync(pHwData, 0x0864, ltmp);
- msleep(5);
+ usleep(5000);
ltmp = (1 << 31) | (0 << 30) | (24 << 24) | 0x3ABA8F;
Wb35Reg_WriteSync(pHwData, 0x0864, ltmp);
- msleep(5);
+ usleep(5000);
ltmp = (1 << 31) | (0 << 30) | (24 << 24) | 0x1ABA8F;
Wb35Reg_WriteSync(pHwData, 0x0864, ltmp);
- msleep(5);
+ usleep(5000);
/* 5GHz */
Wb35Reg_WriteSync(pHwData, 0x03dc, 0x00000000);
@@ -1119,20 +1119,20 @@ void RFSynthesizer_initial(struct hw_data *pHwData)
/* Write to register. number must less and equal than 16 */
for (i = 0; i < number; i++)
Wb35Reg_WriteSync(pHwData, 0x0864, pltmp[i]);
- msleep(5);
+ usleep(5000);
Wb35Reg_WriteSync(pHwData, 0x03dc, 0x00000080);
pr_debug("* PLL_ON high\n");
ltmp = (1 << 31) | (0 << 30) | (24 << 24) | 0x9ABA8F;
Wb35Reg_WriteSync(pHwData, 0x0864, ltmp);
- msleep(5);
+ usleep(5000);
ltmp = (1 << 31) | (0 << 30) | (24 << 24) | 0x3ABA8F;
Wb35Reg_WriteSync(pHwData, 0x0864, ltmp);
- msleep(5);
+ usleep(5000);
ltmp = (1 << 31) | (0 << 30) | (24 << 24) | 0x12BACF;
Wb35Reg_WriteSync(pHwData, 0x0864, ltmp);
- msleep(5);
+ usleep(5000);
break;
case RF_WB_242:
case RF_WB_242_1:
@@ -1147,11 +1147,11 @@ void RFSynthesizer_initial(struct hw_data *pHwData)
/* Calibration (1a.0). Synthesizer reset */
ltmp = (1 << 31) | (0 << 30) | (24 << 24) | BitReverse((0x0F<<24) | 0x00101E, 24);
Wb35Reg_WriteSync(pHwData, 0x0864, ltmp);
- msleep(5);
+ usleep(5000);
/* Calibration (1a). VCO frequency calibration mode ; waiting 2msec VCO calibration time */
ltmp = (1 << 31) | (0 << 30) | (24 << 24) | BitReverse((0x00<<24) | 0xFE69c0, 24);
Wb35Reg_WriteSync(pHwData, 0x0864, ltmp);
- msleep(2);
+ usleep(2000);
/* ----- Calibration (2). TX baseband Gm-C filter auto-tuning */
/* Calibration (2a). turn off ENCAL signal */
@@ -1210,7 +1210,7 @@ void RFSynthesizer_initial(struct hw_data *pHwData)
/* Calibration (5d). turn on RX DC offset cal function; and waiting 2 msec cal time */
ltmp = (1 << 31) | (0 << 30) | (24 << 24) | BitReverse((0x00<<24) | 0xFF6DC0, 24);
Wb35Reg_WriteSync(pHwData, 0x0864, ltmp);
- msleep(2);
+ usleep(2000);
/* Calibration (5f). turn off ENCAL signal */
ltmp = (1 << 31) | (0 << 30) | (24 << 24) | BitReverse((0x00<<24) | 0xFAEDC0, 24);
Wb35Reg_WriteSync(pHwData, 0x0864, ltmp);
@@ -1222,7 +1222,7 @@ void RFSynthesizer_initial(struct hw_data *pHwData)
/* Calibration (5d). turn on RX DC offset cal function; and waiting 2 msec cal time */
ltmp = (1 << 31) | (0 << 30) | (24 << 24) | BitReverse((0x00<<24) | 0xFF6DC0, 24);
Wb35Reg_WriteSync(pHwData, 0x0864, ltmp);
- msleep(2);
+ usleep(2000);
/* Calibration (5f). turn off ENCAL signal */
ltmp = (1 << 31) | (0 << 30) | (24 << 24) | BitReverse((0x00<<24) | 0xFAEDC0, 24);
Wb35Reg_WriteSync(pHwData, 0x0864, ltmp);
@@ -1234,7 +1234,7 @@ void RFSynthesizer_initial(struct hw_data *pHwData)
/* Calibration (5d). turn on RX DC offset cal function; and waiting 2 msec cal time */
ltmp = (1 << 31) | (0 << 30) | (24 << 24) | BitReverse((0x00<<24) | 0xFF6DC0, 24);
Wb35Reg_WriteSync(pHwData, 0x0864, ltmp);
- msleep(2);
+ usleep(2000);
/* Calibration (5f). turn off ENCAL signal */
ltmp = (1 << 31) | (0 << 30) | (24 << 24) | BitReverse((0x00<<24) | 0xFAEDC0, 24);
Wb35Reg_WriteSync(pHwData, 0x0864, ltmp);
@@ -1246,7 +1246,7 @@ void RFSynthesizer_initial(struct hw_data *pHwData)
/* Calibration (5d). turn on RX DC offset cal function; and waiting 2 msec cal time */
ltmp = (1 << 31) | (0 << 30) | (24 << 24) | BitReverse((0x00<<24) | 0xFF6DC0, 24);
Wb35Reg_WriteSync(pHwData, 0x0864, ltmp);
- msleep(2);
+ usleep(2000);
/* Calibration (5f). turn off ENCAL signal */
ltmp = (1 << 31) | (0 << 30) | (24 << 24) | BitReverse((0x00<<24) | 0xFAEDC0, 24);
Wb35Reg_WriteSync(pHwData, 0x0864, ltmp);
@@ -1258,7 +1258,7 @@ void RFSynthesizer_initial(struct hw_data *pHwData)
/* 0x00 0xF86100 ; 3E184 ; Switch RF chip to normal mode */
ltmp = (1 << 31) | (0 << 30) | (24 << 24) | BitReverse((0x00<<24) | 0xF86100, 24);
Wb35Reg_WriteSync(pHwData, 0x0864, ltmp);
- msleep(5);
+ usleep(5000);
break;
}
}
--
1.8.1.2
next prev parent reply other threads:[~2013-09-16 13:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 13:43 [PATCH v2 00/24] Staging: winbond: Fixed some coding style issues Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 01/24] Staging: winbond: mto: removed function declaration Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 02/24] Staging: winbond: mto: avoided use of extern functions Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 03/24] Staging: winbond: mto: deleted " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 04/24] Staging: winbond: phy_calibration: first of the patches that fixes lines over 80 characters Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 05/24] Staging: winbond: phy_calibration: second " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 06/24] Staging: winbond: reg: erased trailing whitespace Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 07/24] Staging: winbond: reg: white space deleted Iker Pedrosa
2013-09-16 13:43 ` Iker Pedrosa [this message]
2013-09-25 23:44 ` [PATCH v2 08/24] Staging: winbond: reg: changed sleep function from msleep to usleep Greg KH
2013-09-16 13:43 ` [PATCH v2 09/24] Staging: winbond: reg: first of the patches that fixes lines over 80 characters Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 10/24] Staging: winbond: reg: second " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 11/24] Staging: winbond: reg: third " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 12/24] Staging: winbond: reg: fourth " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 13/24] Staging: winbond: reg: fifth " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 14/24] Staging: winbond: reg: sixth " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 15/24] Staging: winbond: reg: seventh " Iker Pedrosa
[not found] ` <CANBXnMm7QCab3cU4NMzmA3OjXckcUx5dakyD_TRwfj3j2_02MA@mail.gmail.com>
2013-09-17 9:43 ` Dan Carpenter
2013-09-20 14:45 ` Iker Pedrosa
2013-09-21 9:32 ` Dan Carpenter
2013-09-16 13:43 ` [PATCH v2 16/24] Staging: winbond: wb35reg_f: fixed " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 17/24] Staging: winbond: wb35reg_s: deleted space before tabulation Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 18/24] Staging: winbond: wb35rx: changed sleep function from msleep to usleep Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 19/24] Staging: winbond: wb35rx: fixed some lines over 80 characters Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 20/24] Staging: winbond: wb35tx: changed sleep function from msleep to usleep Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 21/24] Staging: winbond: wb35tx: Replace printk with netdev_err Iker Pedrosa
2013-09-17 16:35 ` Joe Perches
2013-09-25 14:39 ` [PATCH v3 21/24] Staging: winbond: wb35tx: Replace printk with netdev Iker Pedrosa
2013-09-26 0:03 ` Pavel Machek
2013-09-16 13:43 ` [PATCH v2 22/24] Staging: winbond: wb35tx_s: erased the spaces after opening a '[' Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 23/24] Staging: winbond: wbusb: fixed some lines over 80 characters Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 24/24] Staging: winbond: wbusb: changed sleep function from msleep to usleep Iker Pedrosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379339024-12157-9-git-send-email-ikerpedrosam@gmail.com \
--to=ikerpedrosam@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=harsh1kumar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mujeeb.adil@gmail.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®