From: Iker Pedrosa <ikerpedrosam@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Adil Mujeeb <mujeeb.adil@gmail.com>, Pavel Machek <pavel@ucw.cz>,
Greg KH <gregkh@linuxfoundation.org>,
harsh1kumar@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 15/24] Staging: winbond: reg: seventh of the patches that fixes lines over 80 characters
Date: Fri, 20 Sep 2013 16:45:08 +0200 [thread overview]
Message-ID: <20130920164508.ec1ab4101bcc3c77396c943d@gmail.com> (raw)
In-Reply-To: <20130917094326.GO19256@mwanda>
On Tue, 17 Sep 2013 12:43:26 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Tue, Sep 17, 2013 at 02:29:22PM +0530, Adil Mujeeb wrote:
> > Hi,
> >
> >
> > >- PowerData = (1 << 31) | (0 << 30) | (24 << 24) |
> > BitReverse(w89rf242_txvga_data[i][0], 24);
> > >+ PowerData = (1 << 31) | (0 << 30) | (24 << 24)
> > >+ | BitReverse(w89rf242_txvga_data[i][0], 24);
> > .....
> > .....
> >
> > >- reg->M38_MacControl = (DEFAULT_RATE_RETRY_LIMIT << 8) |
> > (DEFAULT_LONG_RETRY_LIMIT << 4) | DEFAULT_SHORT_RETRY_LIMIT;
> > >+ reg->M38_MacControl = (DEFAULT_RATE_RETRY_LIMIT << 8) |
> > >+ (DEFAULT_LONG_RETRY_LIMIT << 4) |
> > >+ DEFAULT_SHORT_RETRY_LIMIT;
> >
> > I think consistency is needed. Either break the lines putting the OR
> > operator ( | ) at the start of new line or at the end of each line. People
> > has its own preference but here you have used both style in single file.
> > Just a suggestion.
> >
>
> Put the '|' character at the end of the line. That's the New Unwritten
> Style Guidelines. Most of the kernel does it this way and it's easier
> to read.
>
> But this could be fixed in a later patch instead of redoing the whole
> series.
>
> regards,
> dan carpenter
>
I will change it for the new version of this patch but I want to wait some days until everybody looks the patches that I've sent.
--
Regards,
Iker Pedrosa <ikerpedrosam@gmail.com>
next prev parent reply other threads:[~2013-09-20 14:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 13:43 [PATCH v2 00/24] Staging: winbond: Fixed some coding style issues Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 01/24] Staging: winbond: mto: removed function declaration Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 02/24] Staging: winbond: mto: avoided use of extern functions Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 03/24] Staging: winbond: mto: deleted " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 04/24] Staging: winbond: phy_calibration: first of the patches that fixes lines over 80 characters Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 05/24] Staging: winbond: phy_calibration: second " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 06/24] Staging: winbond: reg: erased trailing whitespace Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 07/24] Staging: winbond: reg: white space deleted Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 08/24] Staging: winbond: reg: changed sleep function from msleep to usleep Iker Pedrosa
2013-09-25 23:44 ` Greg KH
2013-09-16 13:43 ` [PATCH v2 09/24] Staging: winbond: reg: first of the patches that fixes lines over 80 characters Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 10/24] Staging: winbond: reg: second " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 11/24] Staging: winbond: reg: third " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 12/24] Staging: winbond: reg: fourth " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 13/24] Staging: winbond: reg: fifth " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 14/24] Staging: winbond: reg: sixth " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 15/24] Staging: winbond: reg: seventh " Iker Pedrosa
[not found] ` <CANBXnMm7QCab3cU4NMzmA3OjXckcUx5dakyD_TRwfj3j2_02MA@mail.gmail.com>
2013-09-17 9:43 ` Dan Carpenter
2013-09-20 14:45 ` Iker Pedrosa [this message]
2013-09-21 9:32 ` Dan Carpenter
2013-09-16 13:43 ` [PATCH v2 16/24] Staging: winbond: wb35reg_f: fixed " Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 17/24] Staging: winbond: wb35reg_s: deleted space before tabulation Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 18/24] Staging: winbond: wb35rx: changed sleep function from msleep to usleep Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 19/24] Staging: winbond: wb35rx: fixed some lines over 80 characters Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 20/24] Staging: winbond: wb35tx: changed sleep function from msleep to usleep Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 21/24] Staging: winbond: wb35tx: Replace printk with netdev_err Iker Pedrosa
2013-09-17 16:35 ` Joe Perches
2013-09-25 14:39 ` [PATCH v3 21/24] Staging: winbond: wb35tx: Replace printk with netdev Iker Pedrosa
2013-09-26 0:03 ` Pavel Machek
2013-09-16 13:43 ` [PATCH v2 22/24] Staging: winbond: wb35tx_s: erased the spaces after opening a '[' Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 23/24] Staging: winbond: wbusb: fixed some lines over 80 characters Iker Pedrosa
2013-09-16 13:43 ` [PATCH v2 24/24] Staging: winbond: wbusb: changed sleep function from msleep to usleep Iker Pedrosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130920164508.ec1ab4101bcc3c77396c943d@gmail.com \
--to=ikerpedrosam@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=harsh1kumar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mujeeb.adil@gmail.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome