mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] regulator: wm8350: correct the max_uV of LDO
@ 2013-09-19 12:39 Laxman Dewangan
  2013-09-19 13:16 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Laxman Dewangan @ 2013-09-19 12:39 UTC (permalink / raw)
  To: broonie; +Cc: lgirdwood, linux-kernel, patches, Laxman Dewangan

As per datasheet, voltage range for LDOs are as follows:

	0000 = 0.9V
		...(50mV steps)
	01111 = 1.65V
	10000 = 1.8V
		... (100mV stepns)
	11111 = 3.3V

So, there is no  selector for 1.65V to 1.8V.
Correcting the range for max_uV for selector between 0 to 15.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
When trying to understand the usage of linear_range, found the above issue
in code. I do not have hardware to validate but though that let's send this
for review. Probably this is real bug.

 drivers/regulator/wm8350-regulator.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/regulator/wm8350-regulator.c b/drivers/regulator/wm8350-regulator.c
index a438e93..017e869 100644
--- a/drivers/regulator/wm8350-regulator.c
+++ b/drivers/regulator/wm8350-regulator.c
@@ -543,7 +543,7 @@ static int wm8350_dcdc_set_suspend_mode(struct regulator_dev *rdev,
 }
 
 static const struct regulator_linear_range wm8350_ldo_ranges[] = {
-	{ .min_uV =  900000, .max_uV = 1750000, .min_sel =  0, .max_sel = 15,
+	{ .min_uV =  900000, .max_uV = 1650000, .min_sel =  0, .max_sel = 15,
 	  .uV_step =  50000 },
 	{ .min_uV = 1800000, .max_uV = 3300000, .min_sel = 16, .max_sel = 31,
 	  .uV_step = 100000 },
-- 
1.7.1.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] regulator: wm8350: correct the max_uV of LDO
  2013-09-19 12:39 [PATCH] regulator: wm8350: correct the max_uV of LDO Laxman Dewangan
@ 2013-09-19 13:16 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-09-19 13:16 UTC (permalink / raw)
  To: Laxman Dewangan; +Cc: lgirdwood, linux-kernel, patches

[-- Attachment #1: Type: text/plain, Size: 142 bytes --]

On Thu, Sep 19, 2013 at 06:09:55PM +0530, Laxman Dewangan wrote:
> As per datasheet, voltage range for LDOs are as follows:

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-09-19 13:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-19 12:39 [PATCH] regulator: wm8350: correct the max_uV of LDO Laxman Dewangan
2013-09-19 13:16 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®