* [PATCH V2] regulator: core: set current constraints while setting machine constraints
@ 2013-09-20 7:43 Laxman Dewangan
2013-09-20 9:51 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Laxman Dewangan @ 2013-09-20 7:43 UTC (permalink / raw)
To: broonie; +Cc: lgirdwood, linux-kernel, swarren, Laxman Dewangan
Machine constraints is configured during regulator register. If current
constraints are provided through machine constraints then it is observed
that sometime the current configured on rail is out of range what machine
constraint has.
Set the current constraints when setting machine constraints to make
sure that rail's current is within the range of given machine constraints.
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
Changes from V1:
- Correct the indentng.
- Prints warning when current-ops are not implemented.
- Set constraint current unconditionally.
- Blank line before last return.
drivers/regulator/core.c | 34 ++++++++++++++++++++++++++++++++++
1 files changed, 34 insertions(+), 0 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index b698e2b..bc75cb2 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -904,6 +904,36 @@ static int machine_constraints_voltage(struct regulator_dev *rdev,
return 0;
}
+static int machine_constraints_current(struct regulator_dev *rdev,
+ struct regulation_constraints *constraints)
+{
+ struct regulator_ops *ops = rdev->desc->ops;
+ int ret;
+
+ if (!constraints->min_uA && !constraints->max_uA)
+ return 0;
+
+ if (constraints->min_uA > constraints->max_uA) {
+ rdev_err(rdev, "Invalid current constraints\n");
+ return -EINVAL;
+ }
+
+ if (!ops->set_current_limit || !ops->get_current_limit) {
+ rdev_warn(rdev, "Operation of current configuration missing\n");
+ return 0;
+ }
+
+ /* Set regulator current in constraints range */
+ ret = ops->set_current_limit(rdev, constraints->min_uA,
+ constraints->max_uA);
+ if (ret < 0) {
+ rdev_err(rdev, "Failed to set current constraint, %d\n", ret);
+ return ret;
+ }
+
+ return 0;
+}
+
/**
* set_machine_constraints - sets regulator constraints
* @rdev: regulator source
@@ -934,6 +964,10 @@ static int set_machine_constraints(struct regulator_dev *rdev,
if (ret != 0)
goto out;
+ ret = machine_constraints_current(rdev, rdev->constraints);
+ if (ret != 0)
+ goto out;
+
/* do we need to setup our suspend state */
if (rdev->constraints->initial_state) {
ret = suspend_prepare(rdev, rdev->constraints->initial_state);
--
1.7.1.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH V2] regulator: core: set current constraints while setting machine constraints
2013-09-20 7:43 [PATCH V2] regulator: core: set current constraints while setting machine constraints Laxman Dewangan
@ 2013-09-20 9:51 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-09-20 9:51 UTC (permalink / raw)
To: Laxman Dewangan; +Cc: lgirdwood, linux-kernel, swarren
[-- Attachment #1: Type: text/plain, Size: 326 bytes --]
On Fri, Sep 20, 2013 at 01:13:02PM +0530, Laxman Dewangan wrote:
> Machine constraints is configured during regulator register. If current
> constraints are provided through machine constraints then it is observed
> that sometime the current configured on rail is out of range what machine
> constraint has.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-20 9:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-20 7:43 [PATCH V2] regulator: core: set current constraints while setting machine constraints Laxman Dewangan
2013-09-20 9:51 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®