mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com,
	akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
	josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de,
	peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com,
	edumazet@google.com, darren@dvhart.com, fweisbec@gmail.com,
	sbw@mit.edu, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCH tip/core/rcu 02/13] notifiers: Apply rcu_access_pointer() to avoid sparse false positive
Date: Tue, 24 Sep 2013 18:35:05 -0700	[thread overview]
Message-ID: <1380072916-31557-2-git-send-email-paulmck@linux.vnet.ibm.com> (raw)
In-Reply-To: <1380072916-31557-1-git-send-email-paulmck@linux.vnet.ibm.com>

From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>

The sparse checking for rcu_assign_pointer() was recently upgraded
to reject non-__kernel address spaces.  This also rejects __rcu,
which is almost always the right thing to do.  However, the use in
notifier_chain_unregister() is legitimate: It is deleting an element
from an RCU-protected list, and all elements of this list are already
visible to caller.

This commit therefore silences this false positive by laundering the
pointer using rcu_access_pointer() as suggested by Josh Triplett.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
 kernel/notifier.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/notifier.c b/kernel/notifier.c
index 2d5cc4c..1857c71 100644
--- a/kernel/notifier.c
+++ b/kernel/notifier.c
@@ -51,7 +51,7 @@ static int notifier_chain_unregister(struct notifier_block **nl,
 {
 	while ((*nl) != NULL) {
 		if ((*nl) == n) {
-			rcu_assign_pointer(*nl, n->next);
+			rcu_assign_pointer(*nl, rcu_access_pointer(n->next));
 			return 0;
 		}
 		nl = &((*nl)->next);
-- 
1.8.1.5


  reply	other threads:[~2013-09-25  1:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-25  1:34 [PATCH tip/core/rcu 0/13] Sparse-related updates for 3.13 Paul E. McKenney
2013-09-25  1:35 ` [PATCH tip/core/rcu 01/13] rcu: Make rcu_assign_pointer's assignment volatile and type-safe Paul E. McKenney
2013-09-25  1:35   ` Paul E. McKenney [this message]
2013-09-25  1:35   ` [PATCH tip/core/rcu 03/13] bridge: Apply rcu_access_pointer() to avoid sparse false positive Paul E. McKenney
2013-09-25  1:35   ` [PATCH tip/core/rcu 04/13] wireless: " Paul E. McKenney
2013-09-25 17:48     ` Ben Hutchings
2013-09-25 18:26       ` Paul E. McKenney
2013-09-25  1:35   ` [PATCH tip/core/rcu 05/13] decnet: " Paul E. McKenney
2013-09-25  1:35   ` [PATCH tip/core/rcu 06/13] ipv4/ip_socketglue: " Paul E. McKenney
2013-09-25  1:35   ` [PATCH tip/core/rcu 07/13] ipv6/ip6_tunnel: " Paul E. McKenney
2013-09-25  1:35   ` [PATCH tip/core/rcu 08/13] ipv6/ip6_gre: " Paul E. McKenney
2013-09-25  1:35   ` [PATCH tip/core/rcu 09/13] ipv6/sit: " Paul E. McKenney
2013-09-25  1:35   ` [PATCH tip/core/rcu 10/13] mac80211: " Paul E. McKenney
2013-09-25  1:35   ` [PATCH tip/core/rcu 11/13] bridge/br_mdb: " Paul E. McKenney
2013-09-25  1:35   ` [PATCH tip/core/rcu 12/13] bonding/bond_main: " Paul E. McKenney
2013-09-25  1:35   ` [PATCH tip/core/rcu 13/13] bonding/bond_alb.c: " Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1380072916-31557-2-git-send-email-paulmck@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=darren@dvhart.com \
    --cc=dhowells@redhat.com \
    --cc=dipankar@in.ibm.com \
    --cc=edumazet@google.com \
    --cc=fweisbec@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@kernel.org \
    --cc=niv@us.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sbw@mit.edu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®