From: Ben Hutchings <bhutchings@solarflare.com>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: <linux-kernel@vger.kernel.org>, <mingo@kernel.org>,
<laijs@cn.fujitsu.com>, <dipankar@in.ibm.com>,
<akpm@linux-foundation.org>, <mathieu.desnoyers@efficios.com>,
<josh@joshtriplett.org>, <niv@us.ibm.com>, <tglx@linutronix.de>,
<peterz@infradead.org>, <rostedt@goodmis.org>,
<dhowells@redhat.com>, <edumazet@google.com>, <darren@dvhart.com>,
<fweisbec@gmail.com>, <sbw@mit.edu>,
Stephen Hemminger <stephen@networkplumber.org>,
"David S. Miller" <davem@davemloft.net>,
<bridge@lists.linux-foundation.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH tip/core/rcu 04/13] wireless: Apply rcu_access_pointer() to avoid sparse false positive
Date: Wed, 25 Sep 2013 18:48:23 +0100 [thread overview]
Message-ID: <1380131303.2222.9.camel@bwh-desktop.uk.level5networks.com> (raw)
In-Reply-To: <1380072916-31557-4-git-send-email-paulmck@linux.vnet.ibm.com>
On Tue, 2013-09-24 at 18:35 -0700, Paul E. McKenney wrote:
> From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
>
> The sparse checking for rcu_assign_pointer() was recently upgraded
> to reject non-__kernel address spaces. This also rejects __rcu,
> which is almost always the right thing to do. However, the uses in
> cfg80211_combine_bsses() and cfg80211_bss_update() are legitimate:
> They is assigning a pointer to an element from an RCU-protected list,
[...]
'They is'? This error is also in the commit messsages for the bridge
and mac80211 patches, and maybe others that weren't sent to netdev.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2013-09-25 17:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 1:34 [PATCH tip/core/rcu 0/13] Sparse-related updates for 3.13 Paul E. McKenney
2013-09-25 1:35 ` [PATCH tip/core/rcu 01/13] rcu: Make rcu_assign_pointer's assignment volatile and type-safe Paul E. McKenney
2013-09-25 1:35 ` [PATCH tip/core/rcu 02/13] notifiers: Apply rcu_access_pointer() to avoid sparse false positive Paul E. McKenney
2013-09-25 1:35 ` [PATCH tip/core/rcu 03/13] bridge: " Paul E. McKenney
2013-09-25 1:35 ` [PATCH tip/core/rcu 04/13] wireless: " Paul E. McKenney
2013-09-25 17:48 ` Ben Hutchings [this message]
2013-09-25 18:26 ` Paul E. McKenney
2013-09-25 1:35 ` [PATCH tip/core/rcu 05/13] decnet: " Paul E. McKenney
2013-09-25 1:35 ` [PATCH tip/core/rcu 06/13] ipv4/ip_socketglue: " Paul E. McKenney
2013-09-25 1:35 ` [PATCH tip/core/rcu 07/13] ipv6/ip6_tunnel: " Paul E. McKenney
2013-09-25 1:35 ` [PATCH tip/core/rcu 08/13] ipv6/ip6_gre: " Paul E. McKenney
2013-09-25 1:35 ` [PATCH tip/core/rcu 09/13] ipv6/sit: " Paul E. McKenney
2013-09-25 1:35 ` [PATCH tip/core/rcu 10/13] mac80211: " Paul E. McKenney
2013-09-25 1:35 ` [PATCH tip/core/rcu 11/13] bridge/br_mdb: " Paul E. McKenney
2013-09-25 1:35 ` [PATCH tip/core/rcu 12/13] bonding/bond_main: " Paul E. McKenney
2013-09-25 1:35 ` [PATCH tip/core/rcu 13/13] bonding/bond_alb.c: " Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380131303.2222.9.camel@bwh-desktop.uk.level5networks.com \
--to=bhutchings@solarflare.com \
--cc=akpm@linux-foundation.org \
--cc=bridge@lists.linux-foundation.org \
--cc=darren@dvhart.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niv@us.ibm.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sbw@mit.edu \
--cc=stephen@networkplumber.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®