From: Joe Perches <joe@perches.com>
To: OS Engineering <osengineering@stec-inc.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
Akhil Bhansali <Akhil.Bhansali@hgst.com>,
"jmoyer@redhat.com" <jmoyer@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Amit Phansalkar <Amit.Phansalkar@hgst.com>,
Ramprasad Chinthekindi <Ramprasad.Chinthekindi@hgst.com>
Subject: Re: [PATCH 2/2] skd: Restricted pr_debug() lines to 80 characters
Date: Tue, 01 Oct 2013 11:43:28 -0700 [thread overview]
Message-ID: <1380653008.1924.10.camel@joe-AO722> (raw)
In-Reply-To: <26D762E250385C4D8E9D6EC3C8E47DC11E70588B@sambx4.stec-inc.ad>
On Tue, 2013-10-01 at 12:29 +0000, OS Engineering wrote:
> From 6ff5102b3cd8047bb4bfb4d0165f289249e23bbe Mon Sep 17 00:00:00 2001
> From: rchinthekindi <rchinthekindi@stec-inc.com>
> Date: Tue, 1 Oct 2013 17:49:58 +0530
> Subject: [PATCH 2/2] skd: Restricted pr_debug() lines to 80 characters
>
> Restricted pr_debug() lines to 80 characters
Please don't split formats across multiple lines.
> diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
> @@ -2370,9 +2372,10 @@ static void skd_complete_internal(struct skd_device *skdev,
> skd_send_internal_skspcl(skdev, skspcl, WRITE_BUFFER);
> else {
> if (skdev->state == SKD_DRVR_STATE_STOPPING) {
> - pr_debug("%s:%s:%d TUR failed, don't send anymore"
> - "state 0x%x\n",
> - skdev->name, __func__, __LINE__, skdev->state);
> + pr_debug("%s:%s:%d TUR failed, don't send"
> + " anymore state 0x%x\n",
> + skdev->name, __func__, __LINE__,
> + skdev->state);
etc...
prev parent reply other threads:[~2013-10-01 18:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 12:29 OS Engineering
2013-10-01 18:43 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380653008.1924.10.camel@joe-AO722 \
--to=joe@perches.com \
--cc=Akhil.Bhansali@hgst.com \
--cc=Amit.Phansalkar@hgst.com \
--cc=Ramprasad.Chinthekindi@hgst.com \
--cc=axboe@kernel.dk \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=osengineering@stec-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®