* [PATCH 2/2] skd: Restricted pr_debug() lines to 80 characters
@ 2013-10-01 12:29 OS Engineering
2013-10-01 18:43 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: OS Engineering @ 2013-10-01 12:29 UTC (permalink / raw)
To: axboe
Cc: Akhil Bhansali, jmoyer, linux-kernel, Amit Phansalkar,
Ramprasad Chinthekindi
>From 6ff5102b3cd8047bb4bfb4d0165f289249e23bbe Mon Sep 17 00:00:00 2001
From: rchinthekindi <rchinthekindi@stec-inc.com>
Date: Tue, 1 Oct 2013 17:49:58 +0530
Subject: [PATCH 2/2] skd: Restricted pr_debug() lines to 80 characters
Restricted pr_debug() lines to 80 characters
Signed-off-by: Ramprasad C <ramprasad.chinthekindi@hgst.com>
---
drivers/block/skd_main.c | 29 ++++++++++++++++++-----------
1 files changed, 18 insertions(+), 11 deletions(-)
diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index 9646dcf..30bc45e 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -864,7 +864,8 @@ static void skd_request_fn(struct request_queue *q)
skmsg = skdev->skmsg_free_list;
if (skmsg == NULL) {
pr_debug("%s:%s:%d Out of msg skdev=%p\n",
- skdev->name, __func__, __LINE__, skdev);
+ skdev->name, __func__, __LINE__,
+ skdev);
break;
}
SKD_ASSERT(skmsg->state == SKD_MSG_STATE_IDLE);
@@ -1858,7 +1859,8 @@ static int skd_sg_io_obtain_skspcl(struct skd_device *skdev,
break;
}
- pr_debug("%s:%s:%d blocking\n", skdev->name, __func__, __LINE__);
+ pr_debug("%s:%s:%d blocking\n",
+ skdev->name, __func__, __LINE__);
rc = wait_event_interruptible_timeout(
skdev->waitq,
@@ -2370,9 +2372,10 @@ static void skd_complete_internal(struct skd_device *skdev,
skd_send_internal_skspcl(skdev, skspcl, WRITE_BUFFER);
else {
if (skdev->state == SKD_DRVR_STATE_STOPPING) {
- pr_debug("%s:%s:%d TUR failed, don't send anymore"
- "state 0x%x\n",
- skdev->name, __func__, __LINE__, skdev->state);
+ pr_debug("%s:%s:%d TUR failed, don't send"
+ " anymore state 0x%x\n",
+ skdev->name, __func__, __LINE__,
+ skdev->state);
return;
}
pr_debug("%s:%s:%d **** TUR failed, retry skerr\n",
@@ -2386,9 +2389,10 @@ static void skd_complete_internal(struct skd_device *skdev,
skd_send_internal_skspcl(skdev, skspcl, READ_BUFFER);
else {
if (skdev->state == SKD_DRVR_STATE_STOPPING) {
- pr_debug("%s:%s:%d write buffer failed, don't send"
- " anymore state 0x%x\n",
- skdev->name, __func__, __LINE__, skdev->state);
+ pr_debug("%s:%s:%d write buffer failed,"
+ " don't send anymore state 0x%x\n",
+ skdev->name, __func__, __LINE__,
+ skdev->state);
return;
}
pr_debug("%s:%s:%d "
@@ -3700,11 +3704,13 @@ static void skd_recover_requests(struct skd_device *skdev, int requeue)
if (skspcl->req.state == SKD_REQ_STATE_BUSY) {
if (skspcl->orphaned) {
pr_debug("%s:%s:%d orphaned %p\n",
- skdev->name, __func__, __LINE__, skspcl);
+ skdev->name, __func__, __LINE__,
+ skspcl);
skd_release_special(skdev, skspcl);
} else {
pr_debug("%s:%s:%d not orphaned %p\n",
- skdev->name, __func__, __LINE__, skspcl);
+ skdev->name, __func__, __LINE__,
+ skspcl);
skspcl->req.state = SKD_REQ_STATE_ABORTED;
}
}
@@ -4615,7 +4621,8 @@ static struct skd_device *skd_construct(struct pci_dev *pdev)
return skdev;
err_out:
- pr_debug("%s:%s:%d construct failed\n", skdev->name, __func__, __LINE__);
+ pr_debug("%s:%s:%d construct failed\n",
+ skdev->name, __func__, __LINE__);
skd_destruct(skdev);
return NULL;
}
--
1.7.5.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] skd: Restricted pr_debug() lines to 80 characters
2013-10-01 12:29 [PATCH 2/2] skd: Restricted pr_debug() lines to 80 characters OS Engineering
@ 2013-10-01 18:43 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2013-10-01 18:43 UTC (permalink / raw)
To: OS Engineering
Cc: axboe, Akhil Bhansali, jmoyer, linux-kernel, Amit Phansalkar,
Ramprasad Chinthekindi
On Tue, 2013-10-01 at 12:29 +0000, OS Engineering wrote:
> From 6ff5102b3cd8047bb4bfb4d0165f289249e23bbe Mon Sep 17 00:00:00 2001
> From: rchinthekindi <rchinthekindi@stec-inc.com>
> Date: Tue, 1 Oct 2013 17:49:58 +0530
> Subject: [PATCH 2/2] skd: Restricted pr_debug() lines to 80 characters
>
> Restricted pr_debug() lines to 80 characters
Please don't split formats across multiple lines.
> diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
> @@ -2370,9 +2372,10 @@ static void skd_complete_internal(struct skd_device *skdev,
> skd_send_internal_skspcl(skdev, skspcl, WRITE_BUFFER);
> else {
> if (skdev->state == SKD_DRVR_STATE_STOPPING) {
> - pr_debug("%s:%s:%d TUR failed, don't send anymore"
> - "state 0x%x\n",
> - skdev->name, __func__, __LINE__, skdev->state);
> + pr_debug("%s:%s:%d TUR failed, don't send"
> + " anymore state 0x%x\n",
> + skdev->name, __func__, __LINE__,
> + skdev->state);
etc...
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-01 18:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-01 12:29 [PATCH 2/2] skd: Restricted pr_debug() lines to 80 characters OS Engineering
2013-10-01 18:43 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®