From: Joe Perches <joe@perches.com>
To: "Mathieu Rhéaume" <mathieu@codingrhemes.com>
Cc: gregkh@linuxfoundation.org, arve@android.com,
dan.carpenter@oracle.com, mirsal@mirsal.fr,
serban.constantinescu@arm.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging : android: binder.c: Prefer seq_puts to seq_printf
Date: Tue, 01 Oct 2013 19:19:37 -0700 [thread overview]
Message-ID: <1380680377.2081.27.camel@joe-AO722> (raw)
In-Reply-To: <1380679056-10175-1-git-send-email-mathieu@codingrhemes.com>
On Tue, 2013-10-01 at 21:57 -0400, Mathieu Rhéaume wrote:
> This patch changes seq_printf for seq_puts in binder.c.
> It fixes the warnings emitted by checkpatch.pl.
Please realign function argument to the open parenthesis.
> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
[]
> @@ -3272,7 +3272,7 @@ binder_defer_work(struct binder_proc *proc, enum binder_deferred_state defer)
> static void print_binder_transaction(struct seq_file *m, const char *prefix,
> struct binder_transaction *t)
> {
> - seq_printf(m,
> + seq_puts(m,
> "%s %d: %p from %d:%d to %d:%d code %x flags %x pri %ld r%d",
> prefix, t->debug_id, t,
> t->from ? t->from->proc->pid : 0,
This should be
seq_puts(m, "%s..."
prefix, etc...
using two tabs then 1 space to align to open parenthesis
> @@ -3287,7 +3287,7 @@ static void print_binder_transaction(struct seq_file *m, const char *prefix,
> if (t->buffer->target_node)
> seq_printf(m, " node %d",
> t->buffer->target_node->debug_id);
> - seq_printf(m, " size %zd:%zd data %p\n",
> + seq_puts(m, " size %zd:%zd data %p\n",
> t->buffer->data_size, t->buffer->offsets_size,
seq_puts(m, " size...",
t->buffer->etc...
etc...
next prev parent reply other threads:[~2013-10-02 2:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 1:57 Mathieu Rhéaume
2013-10-02 2:19 ` Joe Perches [this message]
2013-10-02 5:15 ` Ryan Mallon
2013-10-02 6:35 ` Joe Perches
2013-10-02 7:55 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380680377.2081.27.camel@joe-AO722 \
--to=joe@perches.com \
--cc=arve@android.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu@codingrhemes.com \
--cc=mirsal@mirsal.fr \
--cc=serban.constantinescu@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®