From: Joe Perches <joe@perches.com>
To: Ryan Mallon <rmallon@gmail.com>
Cc: "Mathieu Rhéaume" <mathieu@codingrhemes.com>,
gregkh@linuxfoundation.org, arve@android.com,
dan.carpenter@oracle.com, mirsal@mirsal.fr,
serban.constantinescu@arm.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging : android: binder.c: Prefer seq_puts to seq_printf
Date: Tue, 01 Oct 2013 23:35:38 -0700 [thread overview]
Message-ID: <1380695738.2081.33.camel@joe-AO722> (raw)
In-Reply-To: <524BAC04.30501@gmail.com>
On Wed, 2013-10-02 at 15:15 +1000, Ryan Mallon wrote:
> On 02/10/13 11:57, Mathieu Rhéaume wrote:
> > This patch changes seq_printf for seq_puts in binder.c.
> > It fixes the warnings emitted by checkpatch.pl.
[]
> Umm, this won't compile. seq_puts() is defined as:
>
> int seq_puts(struct seq_file *m, const char *s);
>
> checkpatch.pl does indeed complain about uses of seq_printf() in
> drivers/staging/android/binder.c which are passing formatted strings. At
> a quick glance it looks like checkpatch.pl is only checking for the
> format string on the same line as seq_printf(), so this files ugly
> coding style confuses the check. Joe?
True.
This patch should have fixed it. It's in -next already.
https://lkml.org/lkml/2013/9/13/698
> Anyway, please don't blindly change things in the kernel without at
> least compile testing them.
Yes, please.
next prev parent reply other threads:[~2013-10-02 6:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 1:57 Mathieu Rhéaume
2013-10-02 2:19 ` Joe Perches
2013-10-02 5:15 ` Ryan Mallon
2013-10-02 6:35 ` Joe Perches [this message]
2013-10-02 7:55 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380695738.2081.33.camel@joe-AO722 \
--to=joe@perches.com \
--cc=arve@android.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu@codingrhemes.com \
--cc=mirsal@mirsal.fr \
--cc=rmallon@gmail.com \
--cc=serban.constantinescu@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®