* [PATCH] perf tool: don't open-code TEST_EVENTS macro
@ 2013-10-06 10:25 Ramkumar Ramachandra
2013-10-06 11:14 ` Ramkumar Ramachandra
0 siblings, 1 reply; 2+ messages in thread
From: Ramkumar Ramachandra @ 2013-10-06 10:25 UTC (permalink / raw)
To: LKML; +Cc: Robert Richter, Jiri Olsa, Ingo Molnar, Arnaldo Carvalho de Melo
The TEST_EVENTS macro is open-coded towards the end of
test__parse_events(). While at it, undef it cleanly after its usage.
Cc: Robert Richter <robert.richter@amd.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
tools/perf/tests/parse-events.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
index 48114d1..a6f51ff 100644
--- a/tools/perf/tests/parse-events.c
+++ b/tools/perf/tests/parse-events.c
@@ -1531,9 +1531,9 @@ do { \
return ret;
}
- ret1 = test_terms(test__terms, ARRAY_SIZE(test__terms));
- if (!ret2)
- ret2 = ret1;
+ TEST_EVENTS(test__terms);
+
+#undef TEST_EVENTS
return ret2;
}
--
1.8.4.477.g5d89aa9
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] perf tool: don't open-code TEST_EVENTS macro
2013-10-06 10:25 [PATCH] perf tool: don't open-code TEST_EVENTS macro Ramkumar Ramachandra
@ 2013-10-06 11:14 ` Ramkumar Ramachandra
0 siblings, 0 replies; 2+ messages in thread
From: Ramkumar Ramachandra @ 2013-10-06 11:14 UTC (permalink / raw)
To: LKML; +Cc: Jiri Olsa, Ingo Molnar, Arnaldo Carvalho de Melo
Ramkumar Ramachandra wrote:
> The TEST_EVENTS macro is open-coded towards the end of
> test__parse_events(). While at it, undef it cleanly after its usage.
Kindly ignore this patch; I made a trivial mistake.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-06 11:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-06 10:25 [PATCH] perf tool: don't open-code TEST_EVENTS macro Ramkumar Ramachandra
2013-10-06 11:14 ` Ramkumar Ramachandra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®