* [PATCH] tpm: xen-tpmfront: fix missing declaration of xen_domain
@ 2013-10-07 21:45 Rob Herring
2013-10-08 14:30 ` Stefano Stabellini
2013-10-08 15:14 ` [tpmdd-devel] " Ashley D Lai
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2013-10-07 21:45 UTC (permalink / raw)
To: linux-kernel
Cc: stefano.stabellini, Rob Herring, Leonidas Da Silva Barbosa,
Ashley Lai, Rajiv Andrade, Marcel Selhorst, Sirrix AG,
tpmdd-devel
From: Rob Herring <rob.herring@calxeda.com>
xen-tpmfront fails to build on arm64 with the following error:
drivers/char/tpm/xen-tpmfront.c: In function ‘xen_tpmfront_init’:
drivers/char/tpm/xen-tpmfront.c:422:2: error: implicit declaration of function ‘xen_domain’ [-Werror=implicit-function-declaration]
Add include of xen/xen.h to fix this.
Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Cc: Leonidas Da Silva Barbosa <leosilva@linux.vnet.ibm.com>
Cc: Ashley Lai <ashley@ashleylai.com>
Cc: Rajiv Andrade <mail@srajiv.net>
Cc: Marcel Selhorst <tpmdd@selhorst.net>
Cc: Sirrix AG <tpmdd@sirrix.com>
Cc: tpmdd-devel@lists.sourceforge.net
---
drivers/char/tpm/xen-tpmfront.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c
index 06189e5..94c280d 100644
--- a/drivers/char/tpm/xen-tpmfront.c
+++ b/drivers/char/tpm/xen-tpmfront.c
@@ -10,6 +10,7 @@
#include <linux/errno.h>
#include <linux/err.h>
#include <linux/interrupt.h>
+#include <xen/xen.h>
#include <xen/events.h>
#include <xen/interface/io/tpmif.h>
#include <xen/grant_table.h>
--
1.8.1.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tpm: xen-tpmfront: fix missing declaration of xen_domain
2013-10-07 21:45 [PATCH] tpm: xen-tpmfront: fix missing declaration of xen_domain Rob Herring
@ 2013-10-08 14:30 ` Stefano Stabellini
2013-10-08 15:14 ` [tpmdd-devel] " Ashley D Lai
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Stabellini @ 2013-10-08 14:30 UTC (permalink / raw)
To: Rob Herring
Cc: linux-kernel, stefano.stabellini, Rob Herring,
Leonidas Da Silva Barbosa, Ashley Lai, Rajiv Andrade,
Marcel Selhorst, Sirrix AG, tpmdd-devel
[-- Attachment #1: Type: text/plain, Size: 1309 bytes --]
On Mon, 7 Oct 2013, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> xen-tpmfront fails to build on arm64 with the following error:
>
> drivers/char/tpm/xen-tpmfront.c: In function ‘xen_tpmfront_init’:
> drivers/char/tpm/xen-tpmfront.c:422:2: error: implicit declaration of function ‘xen_domain’ [-Werror=implicit-function-declaration]
>
> Add include of xen/xen.h to fix this.
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> Cc: Leonidas Da Silva Barbosa <leosilva@linux.vnet.ibm.com>
> Cc: Ashley Lai <ashley@ashleylai.com>
> Cc: Rajiv Andrade <mail@srajiv.net>
> Cc: Marcel Selhorst <tpmdd@selhorst.net>
> Cc: Sirrix AG <tpmdd@sirrix.com>
> Cc: tpmdd-devel@lists.sourceforge.net
Thanks, added to my queue
> drivers/char/tpm/xen-tpmfront.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c
> index 06189e5..94c280d 100644
> --- a/drivers/char/tpm/xen-tpmfront.c
> +++ b/drivers/char/tpm/xen-tpmfront.c
> @@ -10,6 +10,7 @@
> #include <linux/errno.h>
> #include <linux/err.h>
> #include <linux/interrupt.h>
> +#include <xen/xen.h>
> #include <xen/events.h>
> #include <xen/interface/io/tpmif.h>
> #include <xen/grant_table.h>
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [tpmdd-devel] [PATCH] tpm: xen-tpmfront: fix missing declaration of xen_domain
2013-10-07 21:45 [PATCH] tpm: xen-tpmfront: fix missing declaration of xen_domain Rob Herring
2013-10-08 14:30 ` Stefano Stabellini
@ 2013-10-08 15:14 ` Ashley D Lai
1 sibling, 0 replies; 3+ messages in thread
From: Ashley D Lai @ 2013-10-08 15:14 UTC (permalink / raw)
To: Rob Herring
Cc: linux-kernel, Leonidas Da Silva Barbosa, stefano.stabellini,
Rob Herring, Rajiv Andrade, tpmdd-devel, Sirrix AG
On Mon, 2013-10-07 at 16:45 -0500, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> xen-tpmfront fails to build on arm64 with the following error:
>
Reviewed-by: Ashley Lai <adlai@linux.vnet.ibm.com>
Acked-by: Ashley Lai <adlai@linux.vnet.ibm.com>
Thanks,
--Ashley Lai
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-08 15:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-07 21:45 [PATCH] tpm: xen-tpmfront: fix missing declaration of xen_domain Rob Herring
2013-10-08 14:30 ` Stefano Stabellini
2013-10-08 15:14 ` [tpmdd-devel] " Ashley D Lai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome