mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yi Zhang <yizhang@marvell.com>
To: <broonie@kernel.org>
Cc: <yizhang@marvell.com>, <qiaozhou@marvell.com>,
	<zhangwm@marvell.com>, <yizhang.mrvl@gmail.com>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH] regmap: irq: clear status when disable irq
Date: Mon, 14 Oct 2013 12:23:53 +0800	[thread overview]
Message-ID: <1381724633-29586-1-git-send-email-yizhang@marvell.com> (raw)

clear the status bit if the mask register doesn't prevent
the chip level irq from being asserted

OR in the following sequence, there will be irq storm happens:
1) interrupt is triggered;
2) another thread disables it(the mask bit is set);
3) _Then_ the interrupt thread is not ACKed(the status bit is not cleared),
   and it's ignored;
4) if the irq is still asserted because of the uncleared status bit,
   the irq storm happens;

Change-Id: I371201f365c5a8470073a393068cfeb4e3d14a03
Signed-off-by: Yi Zhang <yizhang@marvell.com>
---
 drivers/base/regmap/regmap-irq.c |   21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c
index d10456f..cd655b8 100644
--- a/drivers/base/regmap/regmap-irq.c
+++ b/drivers/base/regmap/regmap-irq.c
@@ -105,6 +105,27 @@ static void regmap_irq_sync_unlock(struct irq_data *data)
 					"Failed to sync wakes in %x: %d\n",
 					reg, ret);
 		}
+
+		if (!d->chip->init_ack_masked)
+			continue;
+
+		/* Ack masked but set interrupts */
+		reg = d->chip->status_base +
+			(i * map->reg_stride * d->irq_reg_stride);
+		ret = regmap_read(d->map, reg, &d->status_buf[i]);
+		if (ret != 0)
+			dev_err(d->map->dev, "Failed to read IRQ status: %d\n",
+				ret);
+
+		if (d->status_buf[i] && d->chip->ack_base) {
+			reg = d->chip->ack_base +
+				(i * map->reg_stride * d->irq_reg_stride);
+			ret = regmap_write(d->map, reg,
+					d->status_buf[i] & d->mask_buf[i]);
+			if (ret != 0)
+				dev_err(d->map->dev, "Failed to ack 0x%x: %d\n",
+					reg, ret);
+		}
 	}
 
 	if (d->chip->runtime_pm)
-- 
1.7.9.5


             reply	other threads:[~2013-10-14  4:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-14  4:23 Yi Zhang [this message]
2013-10-14 11:09 ` Mark Brown
2013-10-14 11:55   ` Yi Zhang
2013-10-15  5:03 Yi Zhang
2013-10-15 11:48 ` Mark Brown
2013-10-15 12:03   ` Yi Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381724633-29586-1-git-send-email-yizhang@marvell.com \
    --to=yizhang@marvell.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qiaozhou@marvell.com \
    --cc=yizhang.mrvl@gmail.com \
    --cc=zhangwm@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®