From: Yi Zhang <yizhang@marvell.com>
To: <broonie@kernel.org>
Cc: <yizhang@marvell.com>, <zhouqiao@marvell.com>,
<zhangwm@marvell.com>, <yizhang.mrvl@gmail.com>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] regmap: irq: clear status when disable irq
Date: Tue, 15 Oct 2013 13:03:58 +0800 [thread overview]
Message-ID: <1381813438-5386-1-git-send-email-yizhang@marvell.com> (raw)
clear the status bit if the mask register doesn't prevent
the chip level irq from being asserted
OR in the following sequence, there will be irq storm happens:
1) interrupt is triggered;
2) another thread disables it(the mask bit is set);
3) _Then_ the interrupt thread is not ACKed(the status bit is not cleared),
and it's ignored;
4) if the irq is still asserted because of the uncleared status bit,
the irq storm happens;
Signed-off-by: Yi Zhang <yizhang@marvell.com>
---
drivers/base/regmap/regmap-irq.c | 26 +++++++++++++++++++++++++-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c
index d10456f..0784cf4 100644
--- a/drivers/base/regmap/regmap-irq.c
+++ b/drivers/base/regmap/regmap-irq.c
@@ -61,7 +61,7 @@ static void regmap_irq_sync_unlock(struct irq_data *data)
{
struct regmap_irq_chip_data *d = irq_data_get_irq_chip_data(data);
struct regmap *map = d->map;
- int i, ret;
+ int i, j, ret, bits_length;
u32 reg;
if (d->chip->runtime_pm) {
@@ -105,6 +105,30 @@ static void regmap_irq_sync_unlock(struct irq_data *data)
"Failed to sync wakes in %x: %d\n",
reg, ret);
}
+
+ if (!d->chip->init_ack_masked)
+ continue;
+ /*
+ * Ack all the masked interrupts uncondictionly,
+ * OR if there is masked interrupt which hasn't been Acked,
+ * it'll be ignored in irq handler, then may introduce irq storm
+ */
+ if (d->chip->ack_base) {
+ reg = d->chip->ack_base +
+ (i * map->reg_stride * d->irq_reg_stride);
+
+ bits_length = d->map->format.val_bytes * BITS_PER_BYTE;
+ for (j = 0; j < bits_length; j++) {
+ d->mask_buf[i] &= (0x1 << j);
+ if (!d->mask_buf[i])
+ ret = regmap_update_bits(d->map, reg,
+ (0x1 << j), 0);
+ if (ret != 0)
+ dev_err(d->map->dev, "Failed to ack 0x%x: %d\n",
+ reg, ret);
+ }
+ /* no need to sync status_buf, update in irq handler */
+ }
}
if (d->chip->runtime_pm)
--
1.7.9.5
next reply other threads:[~2013-10-15 5:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 5:03 Yi Zhang [this message]
2013-10-15 11:48 ` Mark Brown
2013-10-15 12:03 ` Yi Zhang
-- strict thread matches above, loose matches on Subject: below --
2013-10-14 4:23 Yi Zhang
2013-10-14 11:09 ` Mark Brown
2013-10-14 11:55 ` Yi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381813438-5386-1-git-send-email-yizhang@marvell.com \
--to=yizhang@marvell.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yizhang.mrvl@gmail.com \
--cc=zhangwm@marvell.com \
--cc=zhouqiao@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®