mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Haverkamp <haver@linux.vnet.ibm.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
	cody@linux.vnet.ibm.com, schwidefsky@de.ibm.com,
	utz.bacher@de.ibm.com, jsvogt@de.ibm.com, MIJUNG@de.ibm.com,
	cascardo@linux.vnet.ibm.com, michael@ibmra.de
Subject: Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver v2
Date: Fri, 25 Oct 2013 10:05:14 +0200	[thread overview]
Message-ID: <1382688314.7782.8.camel@oc7383187364.ibm.com> (raw)
In-Reply-To: <20131024100942.GA13614@kroah.com>

Hi Greg,

Am Donnerstag, den 24.10.2013, 11:09 +0100 schrieb Greg KH:
> On Wed, Oct 23, 2013 at 06:15:21PM +0200, Frank Haverkamp wrote:
> > Rework comments:
> >  o Removed __DATE__ macros as suggested by Michal Marek
> >  o Removed startup pr_info() as suggested by Greg KH
> > 
> > Plus some little things we found during test and review:
> >  o Removed some obsolete comments
> >  o Fixed a bug in the initialization path when
> >    genwqe_set_interrupt_capability() fails
> > 
> > Greg, I tried my luck now with git send-email. Please let
> > me know if that works better.
> 
> That's one of the the worst commit message that I've ever seen, you
> really want this as the thing that shows up in the git commit log?
> 

Of course not. Let me fix that. The first posting I did had basically
what I thought should be in the commit log for the 1st inclusion of this
driver.

> I have no idea what this code is, what it does, nor what it should do.


> Also, you are using sysfs, but have no Documetation/ABI/ modifications,
> which isn't allowed.

I will add some information there.

> I need a whole more information before I can even start to review the
> code to try to determine if it's ok or not.
> 
> greg k-h

Ok.

Regards

Frank



  reply	other threads:[~2013-10-25  8:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-23 16:15 Frank Haverkamp
2013-10-24 10:09 ` Greg KH
2013-10-25  8:05   ` Frank Haverkamp [this message]
2013-10-25 10:09   ` [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v3) Frank Haverkamp
2013-10-25 10:09   ` Frank Haverkamp
2013-10-25 10:42     ` Greg KH
2013-10-25 14:00       ` Frank Haverkamp
2013-10-25 15:21         ` Greg KH
2013-10-30 11:19           ` Frank Haverkamp
2013-10-30 13:23             ` Greg KH
2013-10-28  0:52     ` Ryan Mallon
2013-10-30 11:08       ` Frank Haverkamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382688314.7782.8.camel@oc7383187364.ibm.com \
    --to=haver@linux.vnet.ibm.com \
    --cc=MIJUNG@de.ibm.com \
    --cc=arnd@arndb.de \
    --cc=cascardo@linux.vnet.ibm.com \
    --cc=cody@linux.vnet.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jsvogt@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@ibmra.de \
    --cc=schwidefsky@de.ibm.com \
    --cc=utz.bacher@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®