From: Greg KH <gregkh@linuxfoundation.org>
To: Frank Haverkamp <haver@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
cody@linux.vnet.ibm.com, schwidefsky@de.ibm.com,
utz.bacher@de.ibm.com, mmarek@suse.cz, jsvogt@de.ibm.com,
MIJUNG@de.ibm.com, cascardo@linux.vnet.ibm.com, michael@ibmra.de,
Frank Haverkamp <haver@vnet.ibm.com>
Subject: Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v3)
Date: Wed, 30 Oct 2013 06:23:43 -0700 [thread overview]
Message-ID: <20131030132343.GA30447@kroah.com> (raw)
In-Reply-To: <1383131998.16560.106.camel@oc7383187364.ibm.com>
On Wed, Oct 30, 2013 at 12:19:58PM +0100, Frank Haverkamp wrote:
> Hi Greg,
>
> Am Freitag, den 25.10.2013, 16:21 +0100 schrieb Greg KH:
> > On Fri, Oct 25, 2013 at 04:00:44PM +0200, Frank Haverkamp wrote:
> > > > And why are you doing debug stuff through the ioctl interface? Please
> > > > move that to debugfs if you really want/need that information, it does
> > > > not belong in an ioctl.
> > >
> > > I will look into that. We need that information per card when it fails.
> >
> > People put per-card information in debugfs all the time, look at the USB
> > host controller files in debugfs for an example of how to do this.
>
> Thanks for pointing me to the example. I moved some of my former sysfs
> interfaces to debugfs. Especially those which were printing out more
> than one item. I guess you don't like those in sysfs anyways.
It's forbidden, thanks for noticing and fixing that before I had to say
the same thing later...
greg k-h
next prev parent reply other threads:[~2013-10-30 13:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 16:15 [PATCH] Generic WorkQueue Engine (GenWQE) device driver v2 Frank Haverkamp
2013-10-24 10:09 ` Greg KH
2013-10-25 8:05 ` Frank Haverkamp
2013-10-25 10:09 ` [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v3) Frank Haverkamp
2013-10-25 10:09 ` Frank Haverkamp
2013-10-25 10:42 ` Greg KH
2013-10-25 14:00 ` Frank Haverkamp
2013-10-25 15:21 ` Greg KH
2013-10-30 11:19 ` Frank Haverkamp
2013-10-30 13:23 ` Greg KH [this message]
2013-10-28 0:52 ` Ryan Mallon
2013-10-30 11:08 ` Frank Haverkamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030132343.GA30447@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=MIJUNG@de.ibm.com \
--cc=arnd@arndb.de \
--cc=cascardo@linux.vnet.ibm.com \
--cc=cody@linux.vnet.ibm.com \
--cc=haver@linux.vnet.ibm.com \
--cc=haver@vnet.ibm.com \
--cc=jsvogt@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@ibmra.de \
--cc=mmarek@suse.cz \
--cc=schwidefsky@de.ibm.com \
--cc=utz.bacher@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome