mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH trace-cmd] Makefile: Ensure _GNU_SOURCE really is always defined
@ 2013-11-01 14:17 Seth Forshee
  0 siblings, 0 replies; only message in thread
From: Seth Forshee @ 2013-11-01 14:17 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: linux-kernel, Seth Forshee

When CLFAGS is set with a command argument a normal variable
assignment is not sufficient to ensure that _GNU_SOURCE will be
defined. Since this really is critical for building, use an
override directive when adding it to CFLAGS to ensure that it
really does get defined in all cases.

Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 1d613c4..a2ba385 100644
--- a/Makefile
+++ b/Makefile
@@ -223,7 +223,7 @@ CFLAGS ?= -g -Wall
 LDFLAGS ?=
 
 # Required CFLAGS
-CFLAGS += -D_GNU_SOURCE
+override CFLAGS += -D_GNU_SOURCE
 
 ifndef NO_PTRACE
 ifneq ($(call try-cc,$(SOURCE_PTRACE),),y)
-- 
1.8.3.2


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2013-11-01 14:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-01 14:17 [PATCH trace-cmd] Makefile: Ensure _GNU_SOURCE really is always defined Seth Forshee

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®