From: Eric Dumazet <eric.dumazet@gmail.com>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: Andrey Vagin <avagin@openvz.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexei Starovoitov <ast@plumgrid.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
stable@vger.kernel.org.#.3.12
Subject: Re: [PATCH] net: don't forget to free sk_filter
Date: Wed, 06 Nov 2013 11:28:18 -0800 [thread overview]
Message-ID: <1383766098.21999.2.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <527A9638.4020404@redhat.com>
On Wed, 2013-11-06 at 20:19 +0100, Daniel Borkmann wrote:
> When you send v2 with Alexei's feedback, please also be more specific
> in your subject like "net: x86: bpf: don't forget to free sk_filter"
> or the like. Also it's enough to say 'This memory leak was introduced
> by commit d45ed4a4e3 ("net: fix unsafe set_memory_rw from softirq")'
> instead of copying the whole log. Anyways, for v2 with feedback included
> then:
Actually, the new way [1] of doing this would be to use the 'Fixes:' tag
as in :
Fixes: <12 digits SHA1> ("net: fix unsafe set_memory_rw from softirq")
[1] As discussed at last Kernel Summit
Example in
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=6920a1bd037374a632d585de127b6f945199dcb8
next prev parent reply other threads:[~2013-11-06 19:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 15:51 Andrey Vagin
2013-11-06 19:19 ` Daniel Borkmann
2013-11-06 19:28 ` Eric Dumazet [this message]
2013-11-06 19:31 ` Daniel Borkmann
2013-11-06 19:44 ` Alexei Starovoitov
2013-11-06 20:24 ` David Miller
2013-11-08 0:56 ` Keller, Jacob E
2013-11-08 0:58 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383766098.21999.2.camel@edumazet-glaptop2.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=ast@plumgrid.com \
--cc=avagin@openvz.org \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org.#.3.12 \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®