Re: IRQF_RESUME_EARLY and errors in dpm_suspend_noirq

[Ian Campbell <Ian.Campbell@citrix.com>]

On Wed, 2013-11-20 at 15:24 +0530, Laxman Dewangan wrote:
> On Wednesday 20 November 2013 02:50 PM, Heiko Stübner wrote:
> > Hi,
> >
> > Commit 9bab0b7fbace (genirq: Add IRQF_RESUME_EARLY and resume such IRQs
> > earlier) split the suspend/resume of the irqs into two parts.
> >
> > The early-irqs get resumed during syscore_resume, while the rest get
> > resumed by the regular resume_device_irqs.
> >
> > I may be blind, but where get the early-irqs resumed in the error
> > path of dpm_suspend_noirq?
> >
> > When a suspend_noirq callback returns an error, dpm_resume_noirq gets called,
> > which only calls resume_device_irqs while the suspend_device_irqs call in
> > dpm_suspend_noirq suspends all irqs. So it does not seem that the early-irqs
> > get resumed at all in this case.
> >
> I also faced same issue in our suspend failure path and posted fix 
> sometime ago as
> https://lkml.org/lkml/2013/8/13/373
> 
> It is still under review.

IME zero comments since August is not "under review", it is "has slipped
through the cracks" ;-)

I would suggest you resend it.

Ian.