From: Pavel Machek <pavel@ucw.cz>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
Ian Campbell <ian.campbell@citrix.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Thomas Gleixner <tglx@linutronix.de>,
Len Brown <len.brown@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: IRQF_RESUME_EARLY and errors in dpm_suspend_noirq
Date: Sun, 24 Nov 2013 11:41:24 +0100 [thread overview]
Message-ID: <20131124104124.GA22947@amd.pavel.ucw.cz> (raw)
In-Reply-To: <201311232225.48973.heiko@sntech.de>
On Sat 2013-11-23 22:25:48, Heiko Stübner wrote:
> Hi Laxman,
>
> Am Mittwoch, 20. November 2013, 10:54:10 schrieb Laxman Dewangan:
> > > I may be blind, but where get the early-irqs resumed in the error
> > > path of dpm_suspend_noirq?
> > >
> > > When a suspend_noirq callback returns an error, dpm_resume_noirq gets
> > > called, which only calls resume_device_irqs while the
> > > suspend_device_irqs call in dpm_suspend_noirq suspends all irqs. So it
> > > does not seem that the early-irqs get resumed at all in this case.
> >
> > I also faced same issue in our suspend failure path and posted fix
> > sometime ago as
> > https://lkml.org/lkml/2013/8/13/373
> >
> > It is still under review.
If it helps, you can add my
Reviewed-by: Pavel Machek <pavel@ucw.cz>
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2013-11-24 10:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 9:20 Heiko Stübner
2013-11-20 9:54 ` Laxman Dewangan
2013-11-23 21:25 ` Heiko Stübner
2013-11-24 10:41 ` Pavel Machek [this message]
2013-11-24 11:20 ` Pavel Machek
2013-11-25 10:13 ` Ian Campbell
2013-11-25 14:12 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131124104124.GA22947@amd.pavel.ucw.cz \
--to=pavel@ucw.cz \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=ian.campbell@citrix.com \
--cc=ldewangan@nvidia.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®