mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] crypto/caam/jr.c: include linux/of_address.h
@ 2013-11-26  6:30 shh.xie
  2013-11-26  9:43 ` Ruchika Gupta
  0 siblings, 1 reply; 3+ messages in thread
From: shh.xie @ 2013-11-26  6:30 UTC (permalink / raw)
  To: linux-crypto, linux-kernel; +Cc: herbert, davem, Shaohui Xie

From: Shaohui Xie <Shaohui.Xie@freescale.com>

to avoid a compile error:

drivers/crypto/caam/jr.c: In function 'caam_jr_probe':
drivers/crypto/caam/jr.c:468:2: error: implicit declaration of function
'of_iomap' [-Werror=implicit-function-declaration]
drivers/crypto/caam/jr.c:468:7: warning: assignment makes pointer from
integer without a cast [enabled by default]

Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
---
 drivers/crypto/caam/jr.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c
index d23356d2..1d80bd3 100644
--- a/drivers/crypto/caam/jr.c
+++ b/drivers/crypto/caam/jr.c
@@ -6,6 +6,7 @@
  */
 
 #include <linux/of_irq.h>
+#include <linux/of_address.h>
 
 #include "compat.h"
 #include "regs.h"
-- 
1.8.4.1



^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] crypto/caam/jr.c: include linux/of_address.h
  2013-11-26  6:30 [PATCH] crypto/caam/jr.c: include linux/of_address.h shh.xie
@ 2013-11-26  9:43 ` Ruchika Gupta
  2013-11-26 10:05   ` Shaohui Xie
  0 siblings, 1 reply; 3+ messages in thread
From: Ruchika Gupta @ 2013-11-26  9:43 UTC (permalink / raw)
  To: shh.xie, linux-crypto, linux-kernel; +Cc: herbert, davem, Shaohui Xie

[-- Attachment #1: Type: text/plain, Size: 1566 bytes --]

A Patch for this has already been submitted.

Regards,
Ruchika

> -----Original Message-----
> From: linux-crypto-owner@vger.kernel.org [mailto:linux-crypto-
> owner@vger.kernel.org] On Behalf Of shh.xie@gmail.com
> Sent: Tuesday, November 26, 2013 12:00 PM
> To: linux-crypto@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: herbert@gondor.hengli.com.au; davem@davemloft.net; Xie Shaohui-B21989
> Subject: [PATCH] crypto/caam/jr.c: include linux/of_address.h
> 
> From: Shaohui Xie <Shaohui.Xie@freescale.com>
> 
> to avoid a compile error:
> 
> drivers/crypto/caam/jr.c: In function 'caam_jr_probe':
> drivers/crypto/caam/jr.c:468:2: error: implicit declaration of function
> 'of_iomap' [-Werror=implicit-function-declaration]
> drivers/crypto/caam/jr.c:468:7: warning: assignment makes pointer from
> integer without a cast [enabled by default]
> 
> Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> ---
>  drivers/crypto/caam/jr.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c index
> d23356d2..1d80bd3 100644
> --- a/drivers/crypto/caam/jr.c
> +++ b/drivers/crypto/caam/jr.c
> @@ -6,6 +6,7 @@
>   */
> 
>  #include <linux/of_irq.h>
> +#include <linux/of_address.h>
> 
>  #include "compat.h"
>  #include "regs.h"
> --
> 1.8.4.1
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


[-- Attachment #2: Type: message/rfc822, Size: 2317 bytes --]

From: Ruchika Gupta <ruchika.gupta@freescale.com>
To: Michael Neuling <mikey@neuling.org>
Cc: Vakul Garg <vakul@freescale.com>, Herbert Xu <herbert@gondor.apana.org.au>, "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>, "sfr@canb.auug.org.au" <sfr@canb.auug.org.au>
Subject: RE: [PATCH] crypto: caam - Add missing Job Ring include
Date: Tue, 19 Nov 2013 04:17:29 +0000

Acked-by: Ruchika Gupta <ruchika.gupta@freescale.com>

> -----Original Message-----
> From: linux-crypto-owner@vger.kernel.org [mailto:linux-crypto-
> owner@vger.kernel.org] On Behalf Of Michael Neuling
> Sent: Monday, November 18, 2013 9:50 AM
> To: Gupta Ruchika-R66431
> Cc: Garg Vakul-B16394; Herbert Xu; linux-crypto@vger.kernel.org;
> sfr@canb.auug.org.au
> Subject: [PATCH] crypto: caam - Add missing Job Ring include
>
> linuxnext currently doesn't compile with the powerpc mpc85xx_defconfig
> giving:
>
>   drivers/crypto/caam/jr.c: In function 'caam_jr_probe':
>   drivers/crypto/caam/jr.c:468:2: error: implicit declaration of function
> 'of_iomap' [-Werror=implicit-function-declaration]
>
> In:
>   commit 313ea293e9c4d1eabcaddd2c0800f083b03c2a2e
>   Author: Ruchika Gupta <ruchika.gupta@freescale.com>
>   crypto: caam - Add Platform driver for Job Ring
>
> We added a reference to of_iomap but did add the necessary include file.
>
> The below adds this include.
>
> Signed-off-by: Michael Neuling <mikey@neuling.org>
>
> diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c index
> d23356d2..1d80bd3 100644
> --- a/drivers/crypto/caam/jr.c
> +++ b/drivers/crypto/caam/jr.c
> @@ -6,6 +6,7 @@
>   */
>
>  #include <linux/of_irq.h>
> +#include <linux/of_address.h>
>
>  #include "compat.h"
>  #include "regs.h"
> --
> To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
> the body of a message to majordomo@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] crypto/caam/jr.c: include linux/of_address.h
  2013-11-26  9:43 ` Ruchika Gupta
@ 2013-11-26 10:05   ` Shaohui Xie
  0 siblings, 0 replies; 3+ messages in thread
From: Shaohui Xie @ 2013-11-26 10:05 UTC (permalink / raw)
  To: Ruchika Gupta, shh.xie, linux-crypto, linux-kernel; +Cc: herbert, davem

Thanks!
I'm not in the list, did not see the patch.
So just ignore this patch.

Best Regards, 
Shaohui Xie


> -----Original Message-----
> From: Gupta Ruchika-R66431
> Sent: Tuesday, November 26, 2013 5:43 PM
> To: shh.xie@gmail.com; linux-crypto@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: herbert@gondor.hengli.com.au; davem@davemloft.net; Xie Shaohui-B21989
> Subject: RE: [PATCH] crypto/caam/jr.c: include linux/of_address.h
> 
> A Patch for this has already been submitted.
> 
> Regards,
> Ruchika
> 
> > -----Original Message-----
> > From: linux-crypto-owner@vger.kernel.org [mailto:linux-crypto-
> > owner@vger.kernel.org] On Behalf Of shh.xie@gmail.com
> > Sent: Tuesday, November 26, 2013 12:00 PM
> > To: linux-crypto@vger.kernel.org; linux-kernel@vger.kernel.org
> > Cc: herbert@gondor.hengli.com.au; davem@davemloft.net; Xie
> > Shaohui-B21989
> > Subject: [PATCH] crypto/caam/jr.c: include linux/of_address.h
> >
> > From: Shaohui Xie <Shaohui.Xie@freescale.com>
> >
> > to avoid a compile error:
> >
> > drivers/crypto/caam/jr.c: In function 'caam_jr_probe':
> > drivers/crypto/caam/jr.c:468:2: error: implicit declaration of
> > function 'of_iomap' [-Werror=implicit-function-declaration]
> > drivers/crypto/caam/jr.c:468:7: warning: assignment makes pointer from
> > integer without a cast [enabled by default]
> >
> > Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> > ---
> >  drivers/crypto/caam/jr.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c index
> > d23356d2..1d80bd3 100644
> > --- a/drivers/crypto/caam/jr.c
> > +++ b/drivers/crypto/caam/jr.c
> > @@ -6,6 +6,7 @@
> >   */
> >
> >  #include <linux/of_irq.h>
> > +#include <linux/of_address.h>
> >
> >  #include "compat.h"
> >  #include "regs.h"
> > --
> > 1.8.4.1
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> > linux-crypto" in the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-11-26 10:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-26  6:30 [PATCH] crypto/caam/jr.c: include linux/of_address.h shh.xie
2013-11-26  9:43 ` Ruchika Gupta
2013-11-26 10:05   ` Shaohui Xie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®