From: Kent Overstreet <kmo@daterainc.com>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
hch@infradead.org
Cc: Kent Overstreet <kmo@daterainc.com>,
Alasdair Kergon <agk@redhat.com>,
dm-devel@redhat.com
Subject: [PATCH 05/25] dm: Use bvec_iter for dm_bio_record()
Date: Tue, 26 Nov 2013 16:45:08 -0800 [thread overview]
Message-ID: <1385513128-5035-5-git-send-email-kmo@daterainc.com> (raw)
In-Reply-To: <1385513128-5035-1-git-send-email-kmo@daterainc.com>
This patch doesn't itself have any functional changes, but immutable
biovecs are going to add a bi_bvec_done member to bi_iter, which will
need to be saved too here.
Signed-off-by: Kent Overstreet <kmo@daterainc.com>
Cc: Alasdair Kergon <agk@redhat.com>
Cc: dm-devel@redhat.com
Reviewed-by: Mike Snitzer <snitzer@redhat.com>
---
drivers/md/dm-bio-record.h | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/md/dm-bio-record.h b/drivers/md/dm-bio-record.h
index 5ace48e..4f46e8e 100644
--- a/drivers/md/dm-bio-record.h
+++ b/drivers/md/dm-bio-record.h
@@ -28,11 +28,9 @@ struct dm_bio_vec_details {
};
struct dm_bio_details {
- sector_t bi_sector;
struct block_device *bi_bdev;
- unsigned int bi_size;
- unsigned short bi_idx;
unsigned long bi_flags;
+ struct bvec_iter bi_iter;
struct dm_bio_vec_details bi_io_vec[BIO_MAX_PAGES];
};
@@ -40,11 +38,9 @@ static inline void dm_bio_record(struct dm_bio_details *bd, struct bio *bio)
{
unsigned i;
- bd->bi_sector = bio->bi_iter.bi_sector;
bd->bi_bdev = bio->bi_bdev;
- bd->bi_size = bio->bi_iter.bi_size;
- bd->bi_idx = bio->bi_iter.bi_idx;
bd->bi_flags = bio->bi_flags;
+ bd->bi_iter = bio->bi_iter;
for (i = 0; i < bio->bi_vcnt; i++) {
bd->bi_io_vec[i].bv_len = bio->bi_io_vec[i].bv_len;
@@ -56,11 +52,9 @@ static inline void dm_bio_restore(struct dm_bio_details *bd, struct bio *bio)
{
unsigned i;
- bio->bi_iter.bi_sector = bd->bi_sector;
bio->bi_bdev = bd->bi_bdev;
- bio->bi_iter.bi_size = bd->bi_size;
- bio->bi_iter.bi_idx = bd->bi_idx;
bio->bi_flags = bd->bi_flags;
+ bio->bi_iter = bd->bi_iter;
for (i = 0; i < bio->bi_vcnt; i++) {
bio->bi_io_vec[i].bv_len = bd->bi_io_vec[i].bv_len;
--
1.8.4.4
next prev parent reply other threads:[~2013-11-27 0:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 21:52 [GIT PULL] Immutable biovecs Kent Overstreet
2013-11-26 6:05 ` Christoph Hellwig
2013-11-27 0:44 ` Kent Overstreet
2013-11-27 0:45 ` [PATCH 01/25] block: submit_bio_wait() conversions Kent Overstreet
2013-11-27 0:45 ` [PATCH 02/25] block: Convert various code to bio_for_each_segment() Kent Overstreet
2013-11-27 0:45 ` [PATCH 03/25] bcache: Kill unaligned bvec hack Kent Overstreet
2013-11-27 0:45 ` Kent Overstreet [this message]
2013-11-27 0:45 ` [PATCH 06/25] block: Convert bio_iovec() to bvec_iter Kent Overstreet
2013-11-27 0:45 ` [PATCH 08/25] block: Immutable bio vecs Kent Overstreet
2013-11-27 0:45 ` [PATCH 09/25] block: Convert bio_copy_data() to bvec_iter Kent Overstreet
2013-11-27 0:45 ` [PATCH 10/25] bio-integrity: Convert " Kent Overstreet
2013-11-27 0:45 ` [PATCH 11/25] block: Kill bio_segments()/bi_vcnt usage Kent Overstreet
2013-11-27 0:45 ` [PATCH 12/25] block: Convert drivers to immutable biovecs Kent Overstreet
2013-11-27 0:45 ` [PATCH 13/25] aoe: Convert " Kent Overstreet
2013-11-27 0:45 ` [PATCH 14/25] ceph: " Kent Overstreet
2013-11-27 0:45 ` [PATCH 15/25] block: Kill bio_iovec_idx(), __bio_iovec() Kent Overstreet
2013-11-27 0:45 ` [PATCH 16/25] block: Refactor bio_clone_bioset() for immutable biovecs Kent Overstreet
2013-11-27 0:45 ` [PATCH 17/25] block: Add bio_clone_fast() Kent Overstreet
2013-11-27 0:45 ` [PATCH 18/25] rbd: Refactor bio cloning Kent Overstreet
2013-11-27 0:45 ` [PATCH 19/25] dm: Refactor for new bio cloning/splitting Kent Overstreet
2013-11-27 0:45 ` [PATCH 20/25] block: Don't save/copy bvec array anymore Kent Overstreet
2013-11-27 0:45 ` [PATCH 21/25] block: Remove bi_idx hacks Kent Overstreet
2013-11-27 0:45 ` [PATCH 22/25] block: Generic bio chaining Kent Overstreet
2013-11-27 0:45 ` [PATCH 23/25] block: Rename bio_split() -> bio_pair_split() Kent Overstreet
2013-11-27 0:45 ` [PATCH 24/25] block: Introduce new bio_split() Kent Overstreet
2013-11-27 0:45 ` [PATCH 25/25] block: Kill bio_pair_split() Kent Overstreet
[not found] ` <1385513128-5035-4-git-send-email-kmo@daterainc.com>
2013-11-27 18:51 ` [PATCH 04/25] block: Abstract out bvec iterator Geoff Levand
2013-11-27 0:59 ` [GIT PULL] Immutable biovecs Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385513128-5035-5-git-send-email-kmo@daterainc.com \
--to=kmo@daterainc.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome