From: Kent Overstreet <kmo@daterainc.com>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
hch@infradead.org
Cc: Kent Overstreet <kmo@daterainc.com>, Jens Axboe <axboe@kernel.dk>
Subject: [PATCH 09/25] block: Convert bio_copy_data() to bvec_iter
Date: Tue, 26 Nov 2013 16:45:12 -0800 [thread overview]
Message-ID: <1385513128-5035-9-git-send-email-kmo@daterainc.com> (raw)
In-Reply-To: <1385513128-5035-1-git-send-email-kmo@daterainc.com>
Our fancy new bvec iterator makes code like this much easier to write.
Signed-off-by: Kent Overstreet <kmo@daterainc.com>
Cc: Jens Axboe <axboe@kernel.dk>
---
fs/bio.c | 60 +++++++++++++++++++++++++-----------------------------------
1 file changed, 25 insertions(+), 35 deletions(-)
diff --git a/fs/bio.c b/fs/bio.c
index 07b4b7a..f61e59b 100644
--- a/fs/bio.c
+++ b/fs/bio.c
@@ -852,58 +852,48 @@ EXPORT_SYMBOL(bio_alloc_pages);
*/
void bio_copy_data(struct bio *dst, struct bio *src)
{
- struct bio_vec *src_bv, *dst_bv;
- unsigned src_offset, dst_offset, bytes;
+ struct bvec_iter src_iter, dst_iter;
+ struct bio_vec src_bv, dst_bv;
void *src_p, *dst_p;
+ unsigned bytes;
- src_bv = __bio_iovec(src);
- dst_bv = __bio_iovec(dst);
-
- src_offset = src_bv->bv_offset;
- dst_offset = dst_bv->bv_offset;
+ src_iter = src->bi_iter;
+ dst_iter = dst->bi_iter;
while (1) {
- if (src_offset == src_bv->bv_offset + src_bv->bv_len) {
- src_bv++;
- if (src_bv == bio_iovec_idx(src, src->bi_vcnt)) {
- src = src->bi_next;
- if (!src)
- break;
-
- src_bv = __bio_iovec(src);
- }
+ if (!src_iter.bi_size) {
+ src = src->bi_next;
+ if (!src)
+ break;
- src_offset = src_bv->bv_offset;
+ src_iter = src->bi_iter;
}
- if (dst_offset == dst_bv->bv_offset + dst_bv->bv_len) {
- dst_bv++;
- if (dst_bv == bio_iovec_idx(dst, dst->bi_vcnt)) {
- dst = dst->bi_next;
- if (!dst)
- break;
-
- dst_bv = __bio_iovec(dst);
- }
+ if (!dst_iter.bi_size) {
+ dst = dst->bi_next;
+ if (!dst)
+ break;
- dst_offset = dst_bv->bv_offset;
+ dst_iter = dst->bi_iter;
}
- bytes = min(dst_bv->bv_offset + dst_bv->bv_len - dst_offset,
- src_bv->bv_offset + src_bv->bv_len - src_offset);
+ src_bv = bio_iter_iovec(src, src_iter);
+ dst_bv = bio_iter_iovec(dst, dst_iter);
+
+ bytes = min(src_bv.bv_len, dst_bv.bv_len);
- src_p = kmap_atomic(src_bv->bv_page);
- dst_p = kmap_atomic(dst_bv->bv_page);
+ src_p = kmap_atomic(src_bv.bv_page);
+ dst_p = kmap_atomic(dst_bv.bv_page);
- memcpy(dst_p + dst_offset,
- src_p + src_offset,
+ memcpy(dst_p + dst_bv.bv_offset,
+ src_p + src_bv.bv_offset,
bytes);
kunmap_atomic(dst_p);
kunmap_atomic(src_p);
- src_offset += bytes;
- dst_offset += bytes;
+ bio_advance_iter(src, &src_iter, bytes);
+ bio_advance_iter(dst, &dst_iter, bytes);
}
}
EXPORT_SYMBOL(bio_copy_data);
--
1.8.4.4
next prev parent reply other threads:[~2013-11-27 0:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 21:52 [GIT PULL] Immutable biovecs Kent Overstreet
2013-11-26 6:05 ` Christoph Hellwig
2013-11-27 0:44 ` Kent Overstreet
2013-11-27 0:45 ` [PATCH 01/25] block: submit_bio_wait() conversions Kent Overstreet
2013-11-27 0:45 ` [PATCH 02/25] block: Convert various code to bio_for_each_segment() Kent Overstreet
2013-11-27 0:45 ` [PATCH 03/25] bcache: Kill unaligned bvec hack Kent Overstreet
2013-11-27 0:45 ` [PATCH 05/25] dm: Use bvec_iter for dm_bio_record() Kent Overstreet
2013-11-27 0:45 ` [PATCH 06/25] block: Convert bio_iovec() to bvec_iter Kent Overstreet
2013-11-27 0:45 ` [PATCH 08/25] block: Immutable bio vecs Kent Overstreet
2013-11-27 0:45 ` Kent Overstreet [this message]
2013-11-27 0:45 ` [PATCH 10/25] bio-integrity: Convert to bvec_iter Kent Overstreet
2013-11-27 0:45 ` [PATCH 11/25] block: Kill bio_segments()/bi_vcnt usage Kent Overstreet
2013-11-27 0:45 ` [PATCH 12/25] block: Convert drivers to immutable biovecs Kent Overstreet
2013-11-27 0:45 ` [PATCH 13/25] aoe: Convert " Kent Overstreet
2013-11-27 0:45 ` [PATCH 14/25] ceph: " Kent Overstreet
2013-11-27 0:45 ` [PATCH 15/25] block: Kill bio_iovec_idx(), __bio_iovec() Kent Overstreet
2013-11-27 0:45 ` [PATCH 16/25] block: Refactor bio_clone_bioset() for immutable biovecs Kent Overstreet
2013-11-27 0:45 ` [PATCH 17/25] block: Add bio_clone_fast() Kent Overstreet
2013-11-27 0:45 ` [PATCH 18/25] rbd: Refactor bio cloning Kent Overstreet
2013-11-27 0:45 ` [PATCH 19/25] dm: Refactor for new bio cloning/splitting Kent Overstreet
2013-11-27 0:45 ` [PATCH 20/25] block: Don't save/copy bvec array anymore Kent Overstreet
2013-11-27 0:45 ` [PATCH 21/25] block: Remove bi_idx hacks Kent Overstreet
2013-11-27 0:45 ` [PATCH 22/25] block: Generic bio chaining Kent Overstreet
2013-11-27 0:45 ` [PATCH 23/25] block: Rename bio_split() -> bio_pair_split() Kent Overstreet
2013-11-27 0:45 ` [PATCH 24/25] block: Introduce new bio_split() Kent Overstreet
2013-11-27 0:45 ` [PATCH 25/25] block: Kill bio_pair_split() Kent Overstreet
[not found] ` <1385513128-5035-4-git-send-email-kmo@daterainc.com>
2013-11-27 18:51 ` [PATCH 04/25] block: Abstract out bvec iterator Geoff Levand
2013-11-27 0:59 ` [GIT PULL] Immutable biovecs Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385513128-5035-9-git-send-email-kmo@daterainc.com \
--to=kmo@daterainc.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome