From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Marc Kleine-Budde" <mkl@pengutronix.de>
Cc: linux-kernel@vger.kernel.org,
"Evgeniy Polyakov" <zbr@ioremap.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Shawn Guo" <shawn.guo@linaro.org>,
"Sascha Hauer" <kernel@pengutronix.de>
Subject: Re: [PATCH 1/3] w1: mxc_w1: Remove unused field "clkdiv" from private structure
Date: Fri, 29 Nov 2013 15:56:57 +0400 [thread overview]
Message-ID: <1385726217.626946686@f256.i.mail.ru> (raw)
In-Reply-To: <52987EB1.4010503@pengutronix.de>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 444 bytes --]
> On 11/29/2013 12:39 PM, Alexander Shiyan wrote:
> > Private field "clkdiv" is not used outside "probe", so there are
> > no reason to keep it in driver.
>
> Where's the corresponding clk_disable_unprepare()?
I do not see any relation "clk_disable_unprepare" with this patch.
---
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
next prev parent reply other threads:[~2013-11-29 11:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 11:39 Alexander Shiyan
2013-11-29 11:39 ` [PATCH 2/3] w1: mxc_w1: Add warning for base frequency calculation Alexander Shiyan
2013-11-29 11:39 ` [PATCH 3/3] w1: mxc_w1: Check the clk_prepare_enable() return value Alexander Shiyan
2013-11-29 11:46 ` [PATCH 1/3] w1: mxc_w1: Remove unused field "clkdiv" from private structure Marc Kleine-Budde
2013-11-29 11:56 ` Alexander Shiyan [this message]
2013-11-29 12:02 ` Marc Kleine-Budde
2013-11-30 22:51 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385726217.626946686@f256.i.mail.ru \
--to=shc_work@mail.ru \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=shawn.guo@linaro.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®