From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: linux-kernel@vger.kernel.org, Evgeniy Polyakov <zbr@ioremap.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shawn Guo <shawn.guo@linaro.org>,
Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH 1/3] w1: mxc_w1: Remove unused field "clkdiv" from private structure
Date: Fri, 29 Nov 2013 13:02:46 +0100 [thread overview]
Message-ID: <52988266.2020807@pengutronix.de> (raw)
In-Reply-To: <1385726217.626946686@f256.i.mail.ru>
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
On 11/29/2013 12:56 PM, Alexander Shiyan wrote:
>> On 11/29/2013 12:39 PM, Alexander Shiyan wrote:
>>> Private field "clkdiv" is not used outside "probe", so there are
>>> no reason to keep it in driver.
>>
>> Where's the corresponding clk_disable_unprepare()?
>
> I do not see any relation "clk_disable_unprepare" with this patch.
Yes right, sorry for the noise.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2013-11-29 12:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 11:39 Alexander Shiyan
2013-11-29 11:39 ` [PATCH 2/3] w1: mxc_w1: Add warning for base frequency calculation Alexander Shiyan
2013-11-29 11:39 ` [PATCH 3/3] w1: mxc_w1: Check the clk_prepare_enable() return value Alexander Shiyan
2013-11-29 11:46 ` [PATCH 1/3] w1: mxc_w1: Remove unused field "clkdiv" from private structure Marc Kleine-Budde
2013-11-29 11:56 ` Alexander Shiyan
2013-11-29 12:02 ` Marc Kleine-Budde [this message]
2013-11-30 22:51 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52988266.2020807@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=shc_work@mail.ru \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome