* [PATCH] char: tpm: nuvoton: remove unused variable
@ 2013-11-29 17:00 Michal Nazarewicz
2013-11-29 21:12 ` Jason Gunthorpe
0 siblings, 1 reply; 3+ messages in thread
From: Michal Nazarewicz @ 2013-11-29 17:00 UTC (permalink / raw)
To: Jason Gunthorpe, Peter Huewe; +Cc: Dan Morav, tpmdd-devel, linux-kernel
From: Michal Nazarewicz <mina86@mina86.com>
“wait” wait queue is defined but never used in the function, thus
it can be removed.
Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
---
drivers/char/tpm/tpm_i2c_nuvoton.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/char/tpm/tpm_i2c_nuvoton.c b/drivers/char/tpm/tpm_i2c_nuvoton.c
index 6276fea..4f5ac25 100644
--- a/drivers/char/tpm/tpm_i2c_nuvoton.c
+++ b/drivers/char/tpm/tpm_i2c_nuvoton.c
@@ -178,7 +178,6 @@ static int i2c_nuvoton_wait_for_stat(struct tpm_chip *chip, u8 mask, u8 value,
{
if (chip->vendor.irq && queue) {
s32 rc;
- DEFINE_WAIT(wait);
struct priv_data *priv = chip->vendor.priv;
unsigned int cur_intrs = priv->intrs;
--
1.8.4.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] char: tpm: nuvoton: remove unused variable
2013-11-29 17:00 [PATCH] char: tpm: nuvoton: remove unused variable Michal Nazarewicz
@ 2013-11-29 21:12 ` Jason Gunthorpe
2013-12-07 11:42 ` Peter Hüwe
0 siblings, 1 reply; 3+ messages in thread
From: Jason Gunthorpe @ 2013-11-29 21:12 UTC (permalink / raw)
To: Michal Nazarewicz; +Cc: Peter Huewe, Dan Morav, tpmdd-devel, linux-kernel
On Fri, Nov 29, 2013 at 06:00:18PM +0100, Michal Nazarewicz wrote:
> From: Michal Nazarewicz <mina86@mina86.com>
>
> “wait” wait queue is defined but never used in the function, thus
> it can be removed.
>
> Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
> drivers/char/tpm/tpm_i2c_nuvoton.c | 1 -
> 1 file changed, 1 deletion(-)
Acked-By: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Thanks,
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] char: tpm: nuvoton: remove unused variable
2013-11-29 21:12 ` Jason Gunthorpe
@ 2013-12-07 11:42 ` Peter Hüwe
0 siblings, 0 replies; 3+ messages in thread
From: Peter Hüwe @ 2013-12-07 11:42 UTC (permalink / raw)
To: Jason Gunthorpe; +Cc: Michal Nazarewicz, Dan Morav, tpmdd-devel, linux-kernel
Am Freitag, 29. November 2013, 22:12:52 schrieb Jason Gunthorpe:
> On Fri, Nov 29, 2013 at 06:00:18PM +0100, Michal Nazarewicz wrote:
> > From: Michal Nazarewicz <mina86@mina86.com>
> >
> > “wait” wait queue is defined but never used in the function, thus
> > it can be removed.
> >
> > Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
> >
> > drivers/char/tpm/tpm_i2c_nuvoton.c | 1 -
> > 1 file changed, 1 deletion(-)
>
> Acked-By: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
>
> Thanks,
> Jason
Applied.
https://github.com/PeterHuewe/linux-tpmdd/commits/for-james
Thanks
Peter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-07 11:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-29 17:00 [PATCH] char: tpm: nuvoton: remove unused variable Michal Nazarewicz
2013-11-29 21:12 ` Jason Gunthorpe
2013-12-07 11:42 ` Peter Hüwe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome