* [PATCH] netfilter: remove unused variable
@ 2013-11-29 17:03 Michal Nazarewicz
0 siblings, 0 replies; only message in thread
From: Michal Nazarewicz @ 2013-11-29 17:03 UTC (permalink / raw)
To: Pablo Neira Ayuso, Patrick McHardy; +Cc: netfilter, linux-kernel
From: Michal Nazarewicz <mina86@mina86.com>
The nfmsg variable is not used (except in sizeof operator which does
not care about its value) between the first and second time it is
assigned the value. Furthermore, nlmsg_data has no side effects, so
the whole assignment insruction can be safely removed.
Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
---
net/netfilter/nf_tables_api.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
index dcddc49..ebf2f96 100644
--- a/net/netfilter/nf_tables_api.c
+++ b/net/netfilter/nf_tables_api.c
@@ -2501,7 +2501,6 @@ static int nf_tables_dump_set(struct sk_buff *skb, struct netlink_callback *cb)
u32 portid, seq;
int event, err;
- nfmsg = nlmsg_data(cb->nlh);
err = nlmsg_parse(cb->nlh, sizeof(*nfmsg), nla, NFTA_SET_ELEM_LIST_MAX,
nft_set_elem_list_policy);
if (err < 0)
--
1.8.4.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-11-29 17:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-29 17:03 [PATCH] netfilter: remove unused variable Michal Nazarewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome