* [PATCH] staging: silicom: remove dead code
@ 2013-11-29 17:05 Michal Nazarewicz
0 siblings, 0 replies; only message in thread
From: Michal Nazarewicz @ 2013-11-29 17:05 UTC (permalink / raw)
To: Greg Kroah-Hartman, Chad Williamson; +Cc: devel, linux-kernel
From: Michal Nazarewicz <mina86@mina86.com>
bus_info field of struct ethtool_drvinfo is an array thus it always
evaluates to true in a boolean context. Therefore operation
depending on it being false will never be executed.
Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
---
drivers/staging/silicom/bpctl_mod.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c
index 39dc92a..20325f5 100644
--- a/drivers/staging/silicom/bpctl_mod.c
+++ b/drivers/staging/silicom/bpctl_mod.c
@@ -135,8 +135,6 @@ static int bp_get_dev_idx_bsf(struct net_device *dev, int *index)
else
return -EOPNOTSUPP;
- if (!drvinfo.bus_info)
- return -ENODATA;
if (!strcmp(drvinfo.bus_info, "N/A"))
return -ENODATA;
--
1.8.4.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-11-29 17:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-29 17:05 [PATCH] staging: silicom: remove dead code Michal Nazarewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome