* [PATCHv2 1/2] clocksource: zevio-timer: fix compile-time warnings
@ 2013-12-04 9:29 dt.tangr
2013-12-04 9:29 ` [PATCHv2 2/2] arm: nspire: " dt.tangr
0 siblings, 1 reply; 2+ messages in thread
From: dt.tangr @ 2013-12-04 9:29 UTC (permalink / raw)
To: trivial; +Cc: Daniel Tang, tglx, linux-kernel
From: Daniel Tang <dt.tangr@gmail.com>
Fix incorrect function definition of zevio_timer_add so the correct function
pointer is passed to CLOCKSOURCE_OF_DECLARE.
Signed-off-by: Daniel Tang <dt.tangr@gmail.com>
---
drivers/clocksource/zevio-timer.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/clocksource/zevio-timer.c b/drivers/clocksource/zevio-timer.c
index ca81809..a1bd107 100644
--- a/drivers/clocksource/zevio-timer.c
+++ b/drivers/clocksource/zevio-timer.c
@@ -122,28 +122,27 @@ static irqreturn_t zevio_timer_interrupt(int irq, void *dev_id)
return IRQ_HANDLED;
}
-static int __init zevio_timer_add(struct device_node *node)
+static void __init zevio_timer_add(struct device_node *node)
{
struct zevio_timer *timer;
struct resource res;
- int irqnr, ret;
+ int irqnr;
timer = kzalloc(sizeof(*timer), GFP_KERNEL);
if (!timer)
- return -ENOMEM;
+ return;
timer->base = of_iomap(node, 0);
- if (!timer->base) {
- ret = -EINVAL;
+ if (!timer->base)
goto error_free;
- }
+
timer->timer1 = timer->base + IO_TIMER1;
timer->timer2 = timer->base + IO_TIMER2;
timer->clk = of_clk_get(node, 0);
if (IS_ERR(timer->clk)) {
- ret = PTR_ERR(timer->clk);
- pr_err("Timer clock not found! (error %d)\n", ret);
+ pr_err("Timer clock not found! (error %d)\n",
+ (int)PTR_ERR(timer->clk));
goto error_unmap;
}
@@ -204,12 +203,12 @@ static int __init zevio_timer_add(struct device_node *node)
pr_info("Added %s as clocksource\n", timer->clocksource_name);
- return 0;
+ return;
error_unmap:
iounmap(timer->base);
error_free:
kfree(timer);
- return ret;
+ return;
}
CLOCKSOURCE_OF_DECLARE(zevio_timer, "lsi,zevio-timer", zevio_timer_add);
--
1.8.1.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCHv2 2/2] arm: nspire: fix compile-time warnings
2013-12-04 9:29 [PATCHv2 1/2] clocksource: zevio-timer: fix compile-time warnings dt.tangr
@ 2013-12-04 9:29 ` dt.tangr
0 siblings, 0 replies; 2+ messages in thread
From: dt.tangr @ 2013-12-04 9:29 UTC (permalink / raw)
To: trivial; +Cc: Daniel Tang, linux, linux-kernel
From: Daniel Tang <dt.tangr@gmail.com>
Fix nspire_restart to take enum reboot_mode instead of a char so the
correct function pointer is passed to DT_MACHINE_START.
Signed-off-by: Daniel Tang <dt.tangr@gmail.com>
---
arch/arm/mach-nspire/nspire.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-nspire/nspire.c b/arch/arm/mach-nspire/nspire.c
index 4b2ed2e..3d24ebf 100644
--- a/arch/arm/mach-nspire/nspire.c
+++ b/arch/arm/mach-nspire/nspire.c
@@ -63,7 +63,7 @@ static void __init nspire_init(void)
nspire_auxdata, NULL);
}
-static void nspire_restart(char mode, const char *cmd)
+static void nspire_restart(enum reboot_mode mode, const char *cmd)
{
void __iomem *base = ioremap(NSPIRE_MISC_PHYS_BASE, SZ_4K);
if (!base)
--
1.8.1.3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-04 9:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-04 9:29 [PATCHv2 1/2] clocksource: zevio-timer: fix compile-time warnings dt.tangr
2013-12-04 9:29 ` [PATCHv2 2/2] arm: nspire: " dt.tangr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®