From: Ian Campbell <Ian.Campbell@citrix.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
<stefano.stabellini@eu.citrix.com>,
<xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>,
<boris.ostrovsky@oracle.com>, <leosilva@linux.vnet.ibm.com>,
<ashley@ashleylai.com>, <peterhuewe@gmx.de>, <mail@srajiv.net>,
<tpmdd@selhorst.net>, <tpmdd@sirrix.com>,
<dmitry.torokhov@gmail.com>, <bhelgaas@google.com>,
<plagnioj@jcrosoft.com>, <tomi.valkeinen@ti.com>,
<tpmdd-devel@lists.sourceforge.net>,
<linux-input@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-pci@vger.kernel.org>, <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.
Date: Wed, 4 Dec 2013 13:06:36 +0000 [thread overview]
Message-ID: <1386162396.17466.77.camel@kazak.uk.xensource.com> (raw)
In-Reply-To: <529F2758.9070304@citrix.com>
On Wed, 2013-12-04 at 13:00 +0000, David Vrabel wrote:
> On 03/12/13 21:14, Konrad Rzeszutek Wilk wrote:
> >
> > Ian Campbell suggested getting rid of 'xen_platform_pci_unplug'
> > but unfortunatly the xen-blkfront driver is using it, so we
> > cannot do it.
>
> I had a look at what blkfront was using this for and it seems dumb. How
> did we end up with the frontend driver working around toolstack bugs?
> If HVM Linux guest didn't want (e.g.,) PV CDROM, the toolstack shouldn't
> have created one.
Note that this cdrom stuff is actually nothing to do with the unplug
variable -- it just happens to be right next to that check.
Not that the use of the unplug var there doesn't also look pretty odd...
next prev parent reply other threads:[~2013-12-04 13:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 21:14 Konrad Rzeszutek Wilk
2013-12-04 0:03 ` [Xen-devel] " Matthew Daley
2013-12-04 9:37 ` Ian Campbell
2013-12-04 10:51 ` Stefano Stabellini
2013-12-04 10:59 ` Ian Campbell
2013-12-04 11:05 ` Stefano Stabellini
2013-12-04 11:08 ` Ian Campbell
2013-12-04 11:18 ` Stefano Stabellini
2013-12-04 11:23 ` Ian Campbell
2013-12-04 10:48 ` Stefano Stabellini
2013-12-04 13:00 ` David Vrabel
2013-12-04 13:06 ` Ian Campbell [this message]
2013-12-04 16:42 ` Dmitry Torokhov
2013-12-04 16:48 ` Konrad Rzeszutek Wilk
2013-12-04 17:08 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386162396.17466.77.camel@kazak.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=ashley@ashleylai.com \
--cc=bhelgaas@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=dmitry.torokhov@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=leosilva@linux.vnet.ibm.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mail@srajiv.net \
--cc=netdev@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=plagnioj@jcrosoft.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tomi.valkeinen@ti.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
--cc=tpmdd@sirrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®