* [PATCH V2] arm-mmp-build-sram-driver-alone
@ 2013-12-05 1:36 Qiao Zhou
2013-12-05 1:36 ` [PATCH V2] arm: mmp: build sram driver alone Qiao Zhou
0 siblings, 1 reply; 4+ messages in thread
From: Qiao Zhou @ 2013-12-05 1:36 UTC (permalink / raw)
To: eric.y.miao, haojian.zhuang, dan.j.williams, vinod.koul,
linux-kernel, dmaengine, chao.xie
Cc: Qiao Zhou
V2 -> V1:
combine the two patches together according to Dan's suggestion below.
>Please combine the patches for two reasons:
>1/ patch1 by itself makes the problem worse it prevents the mmp_tdma
>driver from building even if CPU_MMP2 is selected.
>2/ patch2 does not have a changelog and is the only user of the
>enabling in patch1
V1 -> V0:
No need for help text for MMP_SRAM in Kconfig and move it into MMP_TDMA
text in Kconfig.
Qiao Zhou (1):
arm: mmp: build sram driver alone
arch/arm/mach-mmp/Kconfig | 3 +++
arch/arm/mach-mmp/Makefile | 3 ++-
drivers/dma/Kconfig | 2 ++
3 files changed, 7 insertions(+), 1 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH V2] arm: mmp: build sram driver alone
2013-12-05 1:36 [PATCH V2] arm-mmp-build-sram-driver-alone Qiao Zhou
@ 2013-12-05 1:36 ` Qiao Zhou
2013-12-05 2:00 ` Dan Williams
0 siblings, 1 reply; 4+ messages in thread
From: Qiao Zhou @ 2013-12-05 1:36 UTC (permalink / raw)
To: eric.y.miao, haojian.zhuang, dan.j.williams, vinod.koul,
linux-kernel, dmaengine, chao.xie
Cc: Qiao Zhou
sram driver can be used by many chips besides CPU_MMP2, and so build
it alone. Also need to select MMP_SRAM for MMP_TDMA driver.
Reported-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Qiao Zhou <zhouqiao@marvell.com>
---
arch/arm/mach-mmp/Kconfig | 3 +++
arch/arm/mach-mmp/Makefile | 3 ++-
drivers/dma/Kconfig | 2 ++
3 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig
index ebdda83..ebdba87 100644
--- a/arch/arm/mach-mmp/Kconfig
+++ b/arch/arm/mach-mmp/Kconfig
@@ -136,4 +136,7 @@ config USB_EHCI_MV_U2O
help
Enables support for OTG controller which can be switched to host mode.
+config MMP_SRAM
+ bool
+
endif
diff --git a/arch/arm/mach-mmp/Makefile b/arch/arm/mach-mmp/Makefile
index 9b702a1..98f0f63 100644
--- a/arch/arm/mach-mmp/Makefile
+++ b/arch/arm/mach-mmp/Makefile
@@ -7,7 +7,8 @@ obj-y += common.o devices.o time.o
# SoC support
obj-$(CONFIG_CPU_PXA168) += pxa168.o
obj-$(CONFIG_CPU_PXA910) += pxa910.o
-obj-$(CONFIG_CPU_MMP2) += mmp2.o sram.o
+obj-$(CONFIG_CPU_MMP2) += mmp2.o
+obj-$(CONFIG_MMP_SRAM) += sram.o
ifeq ($(CONFIG_COMMON_CLK), )
obj-y += clock.o
diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index dd2874e..599f0ae 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -288,9 +288,11 @@ config MMP_TDMA
bool "MMP Two-Channel DMA support"
depends on ARCH_MMP
select DMA_ENGINE
+ select MMP_SRAM
help
Support the MMP Two-Channel DMA engine.
This engine used for MMP Audio DMA and pxa910 SQU.
+ It needs sram driver under mach-mmp.
Say Y here if you enabled MMP ADMA, otherwise say N.
--
1.7.0.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V2] arm: mmp: build sram driver alone
2013-12-05 1:36 ` [PATCH V2] arm: mmp: build sram driver alone Qiao Zhou
@ 2013-12-05 2:00 ` Dan Williams
2013-12-06 7:34 ` Haojian Zhuang
0 siblings, 1 reply; 4+ messages in thread
From: Dan Williams @ 2013-12-05 2:00 UTC (permalink / raw)
To: Qiao Zhou
Cc: Eric Miao, Haojian Zhuang, Vinod Koul, linux-kernel, dmaengine, chao.xie
On Wed, Dec 4, 2013 at 5:36 PM, Qiao Zhou <zhouqiao@marvell.com> wrote:
> sram driver can be used by many chips besides CPU_MMP2, and so build
> it alone. Also need to select MMP_SRAM for MMP_TDMA driver.
>
> Reported-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Qiao Zhou <zhouqiao@marvell.com>
> ---
Looks good, thanks for fixing it up.
--
Dan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V2] arm: mmp: build sram driver alone
2013-12-05 2:00 ` Dan Williams
@ 2013-12-06 7:34 ` Haojian Zhuang
0 siblings, 0 replies; 4+ messages in thread
From: Haojian Zhuang @ 2013-12-06 7:34 UTC (permalink / raw)
To: Dan Williams
Cc: Qiao Zhou, Eric Miao, Vinod Koul, linux-kernel, dmaengine, Chao Xie
On Thu, Dec 5, 2013 at 10:00 AM, Dan Williams <dan.j.williams@intel.com> wrote:
> On Wed, Dec 4, 2013 at 5:36 PM, Qiao Zhou <zhouqiao@marvell.com> wrote:
>> sram driver can be used by many chips besides CPU_MMP2, and so build
>> it alone. Also need to select MMP_SRAM for MMP_TDMA driver.
>>
>> Reported-by: Dan Williams <dan.j.williams@intel.com>
>> Signed-off-by: Qiao Zhou <zhouqiao@marvell.com>
>> ---
>
> Looks good, thanks for fixing it up.
>
> --
> Dan
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-12-06 7:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-05 1:36 [PATCH V2] arm-mmp-build-sram-driver-alone Qiao Zhou
2013-12-05 1:36 ` [PATCH V2] arm: mmp: build sram driver alone Qiao Zhou
2013-12-05 2:00 ` Dan Williams
2013-12-06 7:34 ` Haojian Zhuang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®