From: Ian Campbell <Ian.Campbell@citrix.com>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, Wei Liu <wei.liu2@citrix.com>,
<xen-devel@lists.xenproject.org>, <netdev@vger.kernel.org>,
<josh@joshtriplett.org>
Subject: Re: [PATCH v2 9/9] drivers: net: Mark function xenvif_count_frag_slots() as static in netback.c
Date: Mon, 16 Dec 2013 10:50:10 +0000 [thread overview]
Message-ID: <1387191010.20076.66.camel@kazak.uk.xensource.com> (raw)
In-Reply-To: <609db9fcc843525f9ca2f18673744cad2fb9fb8c.1386911124.git.rashika.kheria@gmail.com>
On Sat, 2013-12-14 at 18:02 +0530, Rashika Kheria wrote:
> This patch marks the function xenvif_count_frag_slots() in netback.c as
> static because they are not used outside this file.
>
> Thus, it also removes the following warning in xen-netback/netback.c:
> drivers/net/xen-netback/netback.c:218:14: warning: no previous prototype for ‘xenvif_count_frag_slots’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
> ---
>
> This revision fixes the following issues of the previous revision:
> Change commit message subject
>
> drivers/net/xen-netback/netback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
> index 64f0e0d..9e4f399 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -215,7 +215,7 @@ struct xenvif_count_slot_state {
> bool head;
> };
>
> -unsigned int xenvif_count_frag_slots(struct xenvif *vif,
> +static unsigned int xenvif_count_frag_slots(struct xenvif *vif,
> unsigned long offset, unsigned long size,
> struct xenvif_count_slot_state *state)
> {
next prev parent reply other threads:[~2013-12-16 10:50 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 12:14 [PATCH v2 1/9] drivers: net: Remove unused function igb_get_eee_status_i354() in e1000_82575.c Rashika Kheria
2013-12-14 12:17 ` [PATCH v2 2/9] drivers: net: Mark functions as static in qlcnic_io.c Rashika Kheria
2013-12-19 8:47 ` [PATCH v3 1/8] " Rashika Kheria
2013-12-19 8:48 ` [PATCH v3 2/8] drivers: net: Mark functions as static in qlcnic_83xx_hw.c Rashika Kheria
2013-12-19 11:51 ` Shahed Shaikh
2013-12-19 23:52 ` David Miller
2013-12-19 8:49 ` [PATCH v3 3/8] drivers: net: Mark functions as static in stmmac_platform.c Rashika Kheria
2013-12-19 23:52 ` David Miller
2013-12-19 8:52 ` [PATCH v3 4/8] drivers: net: Include new header file in sbni.c Rashika Kheria
2013-12-19 23:52 ` David Miller
2013-12-19 8:53 ` [PATCH v3 5/8] drivers: net: Mark functions as static in 3945-debug.c Rashika Kheria
2013-12-19 23:52 ` David Miller
2013-12-19 8:54 ` [PATCH v3 6/8] drivers: net: Mark functions as static in 4965-debug.c Rashika Kheria
2013-12-19 23:52 ` David Miller
2013-12-19 8:55 ` [PATCH v3 7/8] drivers: net: Mark functions as static in debug.c Rashika Kheria
2013-12-19 23:52 ` David Miller
2013-12-19 8:56 ` [PATCH v3 8/8] drivers: net: Mark function xenvif_count_frag_slots() as static in netback.c Rashika Kheria
2013-12-19 11:48 ` Wei Liu
2013-12-19 23:52 ` David Miller
2013-12-20 9:38 ` Paul Durrant
2013-12-19 11:49 ` [PATCH v3 1/8] drivers: net: Mark functions as static in qlcnic_io.c Shahed Shaikh
2013-12-19 23:52 ` David Miller
2013-12-14 12:19 ` [PATCH v2 3/9] drivers: net: Mark functions as static in qlcnic_83xx_hw.c Rashika Kheria
2013-12-14 12:21 ` [PATCH v2 4/9] drivers: net: Mark functions as static in stmmac_platform.c Rashika Kheria
2013-12-14 12:25 ` [PATCH v2 5/9] drivers: net: Put prototype declaration for function sbni_probe() in sbni.c Rashika Kheria
2013-12-14 20:31 ` Josh Triplett
2013-12-15 3:26 ` David Miller
2013-12-15 3:41 ` Josh Triplett
2013-12-15 4:01 ` David Miller
2013-12-14 12:27 ` [PATCH v2 6/9] drivers: net: Mark functions as static in 3945-debug.c Rashika Kheria
2013-12-14 12:28 ` [PATCH v2 7/9] drivers: net: Mark functions as static in 4965-debug.c Rashika Kheria
2013-12-14 12:29 ` [PATCH v2 1/9] drivers: net: Remove unused function igb_get_eee_status_i354() in e1000_82575.c Jeff Kirsher
2013-12-14 12:30 ` [PATCH v2 8/9] drivers: net: Mark functions as static in debug.c Rashika Kheria
2013-12-14 12:32 ` [PATCH v2 9/9] drivers: net: Mark function xenvif_count_frag_slots() as static in netback.c Rashika Kheria
2013-12-16 10:50 ` Ian Campbell [this message]
2013-12-16 17:11 ` [PATCH v2 1/9] drivers: net: Remove unused function igb_get_eee_status_i354() in e1000_82575.c Wyborny, Carolyn
2013-12-16 17:43 ` Josh Triplett
2013-12-16 18:17 ` Wyborny, Carolyn
2013-12-16 18:22 ` Josh Triplett
2013-12-16 18:51 ` Wyborny, Carolyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387191010.20076.66.camel@kazak.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®