From: Rashika Kheria <rashika.kheria@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Bruce Allan <bruce.w.allan@intel.com>,
Carolyn Wyborny <carolyn.wyborny@intel.com>,
Don Skidmore <donald.c.skidmore@intel.com>,
Greg Rose <gregory.v.rose@intel.com>,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
Alex Duyck <alexander.h.duyck@intel.com>,
John Ronciak <john.ronciak@intel.com>,
Tushar Dave <tushar.n.dave@intel.com>,
Akeem G Abodunrin <akeem.g.abodunrin@intel.com>,
Matthew Vick <matthew.vick@intel.com>,
e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
josh@joshtriplett.org
Subject: [PATCH v2 1/9] drivers: net: Remove unused function igb_get_eee_status_i354() in e1000_82575.c
Date: Sat, 14 Dec 2013 17:44:36 +0530 [thread overview]
Message-ID: <a610f6ee6bb992b91e43bdc851f3db62fc3decd5.1386911123.git.rashika.kheria@gmail.com> (raw)
This patch removes the function igb_get_eee_status_i354() in
e1000_82575.c because it is unused.
It thus eliminates the following warning in
ethernet/intel/igb/e1000_82575.c:
drivers/net/ethernet/intel/igb/e1000_82575.c:2591:5: warning: no previous prototype for ‘igb_get_eee_status_i354’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
drivers/net/ethernet/intel/igb/e1000_82575.c | 32 --------------------------
1 file changed, 32 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/e1000_82575.c b/drivers/net/ethernet/intel/igb/e1000_82575.c
index 47c2d10..18e5200 100644
--- a/drivers/net/ethernet/intel/igb/e1000_82575.c
+++ b/drivers/net/ethernet/intel/igb/e1000_82575.c
@@ -2580,38 +2580,6 @@ out:
return ret_val;
}
-/**
- * igb_get_eee_status_i354 - Get EEE status
- * @hw: pointer to the HW structure
- * @status: EEE status
- *
- * Get EEE status by guessing based on whether Tx or Rx LPI indications have
- * been received.
- **/
-s32 igb_get_eee_status_i354(struct e1000_hw *hw, bool *status)
-{
- struct e1000_phy_info *phy = &hw->phy;
- s32 ret_val = 0;
- u16 phy_data;
-
- /* Check if EEE is supported on this device. */
- if ((hw->phy.media_type != e1000_media_type_copper) ||
- (phy->id != M88E1543_E_PHY_ID))
- goto out;
-
- ret_val = igb_read_xmdio_reg(hw, E1000_PCS_STATUS_ADDR_I354,
- E1000_PCS_STATUS_DEV_I354,
- &phy_data);
- if (ret_val)
- goto out;
-
- *status = phy_data & (E1000_PCS_STATUS_TX_LPI_RCVD |
- E1000_PCS_STATUS_RX_LPI_RCVD) ? true : false;
-
-out:
- return ret_val;
-}
-
static const u8 e1000_emc_temp_data[4] = {
E1000_EMC_INTERNAL_DATA,
E1000_EMC_DIODE1_DATA,
--
1.7.9.5
next reply other threads:[~2013-12-14 12:14 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 12:14 Rashika Kheria [this message]
2013-12-14 12:17 ` [PATCH v2 2/9] drivers: net: Mark functions as static in qlcnic_io.c Rashika Kheria
2013-12-19 8:47 ` [PATCH v3 1/8] " Rashika Kheria
2013-12-19 8:48 ` [PATCH v3 2/8] drivers: net: Mark functions as static in qlcnic_83xx_hw.c Rashika Kheria
2013-12-19 11:51 ` Shahed Shaikh
2013-12-19 23:52 ` David Miller
2013-12-19 8:49 ` [PATCH v3 3/8] drivers: net: Mark functions as static in stmmac_platform.c Rashika Kheria
2013-12-19 23:52 ` David Miller
2013-12-19 8:52 ` [PATCH v3 4/8] drivers: net: Include new header file in sbni.c Rashika Kheria
2013-12-19 23:52 ` David Miller
2013-12-19 8:53 ` [PATCH v3 5/8] drivers: net: Mark functions as static in 3945-debug.c Rashika Kheria
2013-12-19 23:52 ` David Miller
2013-12-19 8:54 ` [PATCH v3 6/8] drivers: net: Mark functions as static in 4965-debug.c Rashika Kheria
2013-12-19 23:52 ` David Miller
2013-12-19 8:55 ` [PATCH v3 7/8] drivers: net: Mark functions as static in debug.c Rashika Kheria
2013-12-19 23:52 ` David Miller
2013-12-19 8:56 ` [PATCH v3 8/8] drivers: net: Mark function xenvif_count_frag_slots() as static in netback.c Rashika Kheria
2013-12-19 11:48 ` Wei Liu
2013-12-19 23:52 ` David Miller
2013-12-20 9:38 ` Paul Durrant
2013-12-19 11:49 ` [PATCH v3 1/8] drivers: net: Mark functions as static in qlcnic_io.c Shahed Shaikh
2013-12-19 23:52 ` David Miller
2013-12-14 12:19 ` [PATCH v2 3/9] drivers: net: Mark functions as static in qlcnic_83xx_hw.c Rashika Kheria
2013-12-14 12:21 ` [PATCH v2 4/9] drivers: net: Mark functions as static in stmmac_platform.c Rashika Kheria
2013-12-14 12:25 ` [PATCH v2 5/9] drivers: net: Put prototype declaration for function sbni_probe() in sbni.c Rashika Kheria
2013-12-14 20:31 ` Josh Triplett
2013-12-15 3:26 ` David Miller
2013-12-15 3:41 ` Josh Triplett
2013-12-15 4:01 ` David Miller
2013-12-14 12:27 ` [PATCH v2 6/9] drivers: net: Mark functions as static in 3945-debug.c Rashika Kheria
2013-12-14 12:28 ` [PATCH v2 7/9] drivers: net: Mark functions as static in 4965-debug.c Rashika Kheria
2013-12-14 12:29 ` [PATCH v2 1/9] drivers: net: Remove unused function igb_get_eee_status_i354() in e1000_82575.c Jeff Kirsher
2013-12-14 12:30 ` [PATCH v2 8/9] drivers: net: Mark functions as static in debug.c Rashika Kheria
2013-12-14 12:32 ` [PATCH v2 9/9] drivers: net: Mark function xenvif_count_frag_slots() as static in netback.c Rashika Kheria
2013-12-16 10:50 ` Ian Campbell
2013-12-16 17:11 ` [PATCH v2 1/9] drivers: net: Remove unused function igb_get_eee_status_i354() in e1000_82575.c Wyborny, Carolyn
2013-12-16 17:43 ` Josh Triplett
2013-12-16 18:17 ` Wyborny, Carolyn
2013-12-16 18:22 ` Josh Triplett
2013-12-16 18:51 ` Wyborny, Carolyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a610f6ee6bb992b91e43bdc851f3db62fc3decd5.1386911123.git.rashika.kheria@gmail.com \
--to=rashika.kheria@gmail.com \
--cc=akeem.g.abodunrin@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.vick@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=tushar.n.dave@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®